From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhQBw-0005v6-Cw for qemu-devel@nongnu.org; Mon, 05 May 2014 17:12:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhQBr-0006VT-ER for qemu-devel@nongnu.org; Mon, 05 May 2014 17:12:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhQBr-0006V4-5z for qemu-devel@nongnu.org; Mon, 05 May 2014 17:12:47 -0400 Message-ID: <5367FEC9.7020100@redhat.com> Date: Mon, 05 May 2014 15:12:41 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399034675-17844-1-git-send-email-armbru@redhat.com> <1399034675-17844-12-git-send-email-armbru@redhat.com> In-Reply-To: <1399034675-17844-12-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nEesR2QuuUlEcM5gf2rmHicVhQjCfHiTE" Subject: Re: [Qemu-devel] [PATCH 11/13] tests: Don't call visit_end_struct() after visit_start_struct() fails List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: vilanova@ac.upc.edu, pbonzini@redhat.com, akong@redhat.com, mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nEesR2QuuUlEcM5gf2rmHicVhQjCfHiTE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/02/2014 06:44 AM, Markus Armbruster wrote: > When visit_start_struct() succeeds, visit_end_struct() must not be As in 10/13, s/succeeds/fails/ > called. Three out of four visit_type_TestStruct() call it anyway. As > far as I can tell, visit_start_struct() doesn't actually fail there. > Fix them anyway. >=20 > Signed-off-by: Markus Armbruster > --- > tests/test-qmp-input-strict.c | 18 +++++++++++++----- > tests/test-qmp-output-visitor.c | 18 +++++++++++++----- > tests/test-visitor-serialization.c | 18 +++++++++++++----- > 3 files changed, 39 insertions(+), 15 deletions(-) >=20 With commit message fixed, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nEesR2QuuUlEcM5gf2rmHicVhQjCfHiTE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTZ/7JAAoJEKeha0olJ0Nq+gMH/ioxKg0LzlA5TbO1ezqDLrrt mW7xqjcw1IieqHISVugrysWLzBiCUesQ2zUMGlJAtjNJc+0VWEakzS2d+nY0NQeU 1RIVAg3WmCLYR5daIPJLqZLP8987pJmgUZNy81cWZKJDx9ywAniodhjW7hcRqRFc HivtbZiBUazcGbxlBLx4vva8CYqR2z9VAGWycgF3zqvj6oJfuuIIPfKYTCw81Xwf 6KY+NkbULoyoSlkt9OuQia0kYQAQaYAxLPCJ3e4r3+uveHwnBH4EW6bVjBx3ytdE x5+0BapwTKyEIFcKyeD21dFfBAn60FGkvMR5nAgwPcrvHjPWs3XTlR1ZgKR4SBI= =Bz3E -----END PGP SIGNATURE----- --nEesR2QuuUlEcM5gf2rmHicVhQjCfHiTE--