From: Paolo Bonzini <pbonzini@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>, Amos Kong <akong@redhat.com>
Cc: armbru@redhat.com, famz@redhat.com, qemu-devel@nongnu.org,
anthony@codemonkey.ws, mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v3 0/2] qapi: fix coding style in generated code
Date: Mon, 05 May 2014 23:22:05 +0200 [thread overview]
Message-ID: <536800FD.3000708@redhat.com> (raw)
In-Reply-To: <20140505165104.0d54b9f5@redhat.com>
Il 05/05/2014 22:51, Luiz Capitulino ha scritto:
> On Mon, 28 Apr 2014 15:02:35 +0800
> Amos Kong <akong@redhat.com> wrote:
>
>> Not a serious issue, but it's helpful if we can fix it.
>>
>> V2: split change of scripts/qapi-visit.py to a split patch,
>> eat space by using a special char as Markus suggested
>> V3: update commitlog, update special string, fix of adding
>> const replace string by pattern
>>
>> Amos Kong (3):
>> qapi: fix coding style in parameters list
>> qapi: add const prefix to 'char *' insider c_type()
>> qapi: Suppress unwanted space between type and identifier
>
> Applied to the qmp branch.
>
> The last conflicts with another patch I applied to my tree (both
> are importing re module). I fixed it myself by dropping your import.
>
Did you address my comment at
http://lists.nongnu.org/archive/html/qemu-devel/2014-04/msg04445.html
while applying, too?
Paolo
next prev parent reply other threads:[~2014-05-05 21:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1398668558-16687-1-git-send-email-akong@redhat.com>
2014-05-05 20:51 ` [Qemu-devel] [PATCH v3 0/2] qapi: fix coding style in generated code Luiz Capitulino
2014-05-05 20:56 ` Luiz Capitulino
2014-05-05 21:22 ` Paolo Bonzini [this message]
2014-05-06 13:00 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536800FD.3000708@redhat.com \
--to=pbonzini@redhat.com \
--cc=akong@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).