From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhS0M-0005nu-QF for qemu-devel@nongnu.org; Mon, 05 May 2014 19:09:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhS0I-0004VU-Bk for qemu-devel@nongnu.org; Mon, 05 May 2014 19:09:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26751) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhS0I-0004VQ-2G for qemu-devel@nongnu.org; Mon, 05 May 2014 19:08:58 -0400 Message-ID: <53681A06.3080205@redhat.com> Date: Mon, 05 May 2014 17:08:54 -0600 From: Eric Blake MIME-Version: 1.0 References: <1398762656-26079-1-git-send-email-cyliu@suse.com> <1398762656-26079-21-git-send-email-cyliu@suse.com> In-Reply-To: <1398762656-26079-21-git-send-email-cyliu@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mffQ71qdkoqDmbFeB02Lr2FbxRnlSn0Lf" Subject: Re: [Qemu-devel] [PATCH V26 20/32] qed.c: replace QEMUOptionParameter with QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu , qemu-devel@nongnu.org Cc: stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mffQ71qdkoqDmbFeB02Lr2FbxRnlSn0Lf Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/29/2014 03:10 AM, Chunyan Liu wrote: > One extra change is to define QED_DEFAULT_CLUSTER_SIZE =3D 65536 instea= d > of 64 * 1024; because: > according to existing create_options, "cluster size" has default value = =3D > QED_DEFAULT_CLUSTER_SIZE, after switching to create_opts, this has to b= e > stringized and set to .def_value_str. That is, > .def_value_str =3D stringify(QED_DEFAULT_CLUSTER_SIZE), > so the QED_DEFAULT_CLUSTER_SIZE could not be a expression. >=20 > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block/qed.c | 114 ++++++++++++++++++++++++++++++++--------------------= -------- > block/qed.h | 3 +- > 2 files changed, 61 insertions(+), 56 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --mffQ71qdkoqDmbFeB02Lr2FbxRnlSn0Lf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTaBoGAAoJEKeha0olJ0NqcuMH/1UHhUj5AgkSdQpgAzJqHf9r f7S9obWFSxrEx7AGzZQVxNrpXcuJ7fJq8zKZAPg9lgVoaCj2PtKWI0Pl6x2hMKRs 61IFp7StaOvtJAg01yny+/0CS4iPoE7lTI2G0IaqCD5J4nDaHL9m0X5Utp5E0/LK Mhif/maNQkW2aYZHC6KSpBRrWZquYFPjSmAmgH16SEaa9hOTXxmAZHNFLMXkNohC 7rRstSw9PDg9RAiN4faD3sr5rh2jK1pFp4daSYQBU70r0uVe5zu0E7ptVO/ruQEm q0K37iDhS7FByoM18+W+Hy2YhceVT6doTj87tLIS6zmfRXY4nt4o98Xdyfvvd5U= =75TQ -----END PGP SIGNATURE----- --mffQ71qdkoqDmbFeB02Lr2FbxRnlSn0Lf--