From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Whba1-0004bq-K2 for qemu-devel@nongnu.org; Tue, 06 May 2014 05:22:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhbZx-0002gl-8V for qemu-devel@nongnu.org; Tue, 06 May 2014 05:22:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhbZx-0002gA-1X for qemu-devel@nongnu.org; Tue, 06 May 2014 05:22:25 -0400 Message-ID: <5368A9BC.1070802@redhat.com> Date: Tue, 06 May 2014 12:22:04 +0300 From: Alon Levy MIME-Version: 1.0 References: <1398751349-20869-1-git-send-email-mjt@msgid.tls.msk.ru> <5367A4FA.4040000@redhat.com> <5367BDF1.3020201@msgid.tls.msk.ru> In-Reply-To: <5367BDF1.3020201@msgid.tls.msk.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/5] glib thread interface and libcacard cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev , qemu-devel On 05/05/2014 07:36 PM, Michael Tokarev wrote: > 05.05.2014 18:49, Alon Levy wrote: >> On 04/29/2014 09:02 AM, Michael Tokarev wrote: >>> Basically libgthread has been rewritten in glib version 2.31, and old ways >>> to use thread primitives stopped working while new ways appeared. The two >>> interfaces were sufficiently different to warrant large ifdeffery across all >>> code using it. > [...] > [] >> Reviewed-by: Alon Levy >> Tested-by: Alon Levy > > Hmm. Now I'm a bit confused. Which version did you test? :) > > I posted a v2 patch which splits one of the changes into two > (pstrcpy to memcpy conversion in libcacard), added some more > (minor) changes (which should not affect libcacard code in > any way), and adjusted commit messages. > > The main code is not affected (or should not be), so Tested-by > probably may stay, except of the pstrcpy to memcpy patch > (http://patchwork.ozlabs.org/patch/345002/) which may affect > libcacard. > > Here's the v2: http://lists.gnu.org/archive/html/qemu-devel/2014-05/msg00286.html > > If you tested the git branch which I referred to, that's the > v2, not original submission which you're replying to. I've tested and reviewed 7191b2c43eecc52994924245720c534ea1a0dc84 so v2, my bad. > >> This would be nice to have too (it has nothing to do with your patchset, >> but it would save me a pull request): >> >> commit 2fc95f8bc1912e2de243389d9d102a5a28267f31 >> Author: Alon Levy >> Date: Mon May 5 17:41:32 2014 +0300 >> >> libcacard: remove unnecessary EOL from debug prints > > Well, this can easily go to -trivial, as I'm planning to send a pull > request for it soon anyway. > > Thank you! > > /mjt >