From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40680) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Whgst-00009N-Fu for qemu-devel@nongnu.org; Tue, 06 May 2014 11:02:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Whgsl-0006xk-8s for qemu-devel@nongnu.org; Tue, 06 May 2014 11:02:19 -0400 Received: from cantor2.suse.de ([195.135.220.15]:36322 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Whgsk-0006wl-VI for qemu-devel@nongnu.org; Tue, 06 May 2014 11:02:11 -0400 Message-ID: <5368F971.7080602@suse.de> Date: Tue, 06 May 2014 17:02:09 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <33183CC9F5247A488A2544077AF19020815E2DF1@SZXEMA503-MBS.china.huawei.com> <535BA2E4.4040202@redhat.com> <33183CC9F5247A488A2544077AF19020815E2FE4@SZXEMA503-MBS.china.huawei.com> <20140430000103.GA7429@Inspiron-3521> <33183CC9F5247A488A2544077AF19020815E5FB6@SZXEMA503-MBS.china.huawei.com> <87d2fr1bnu.fsf@blackfin.pond.sub.org> <33183CC9F5247A488A2544077AF19020815E61A2@SZXEMA503-MBS.china.huawei.com> <5368E566.7070900@suse.de> <33183CC9F5247A488A2544077AF19020815E6272@SZXEMA503-MBS.china.huawei.com> <5368EA6C.5080902@suse.de> <33183CC9F5247A488A2544077AF19020815E62A1@SZXEMA503-MBS.china.huawei.com> In-Reply-To: <33183CC9F5247A488A2544077AF19020815E62A1@SZXEMA503-MBS.china.huawei.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Crucial bug] Qemu-2.0.0 do not support virtio-net hot plug/unplug exceed two times List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" Cc: Peter Maydell , "Michael S. Tsirkin" , "qemu-devel@nongnu.org" , Markus Armbruster , Hani Benhabiles , Paolo Bonzini Hi, Am 06.05.2014 16:08, schrieb Gonglei (Arei): >> -----Original Message----- >> From: Andreas F=E4rber [mailto:afaerber@suse.de] >> Sent: Tuesday, May 06, 2014 9:58 PM >> To: Gonglei (Arei) >> Cc: Markus Armbruster; Hani Benhabiles; Peter Maydell; Paolo Bonzini; >> Michael S. Tsirkin; qemu-devel@nongnu.org >> Subject: Re: [Qemu-devel] [Crucial bug] Qemu-2.0.0 do not support virt= io-net >> hot plug/unplug exceed two times >> >> Am 06.05.2014 15:41, schrieb Gonglei (Arei): >>>> >>>> Am 06.05.2014 14:52, schrieb Gonglei (Arei): >>>>> Step 1: I executed "device_add virtio-net-pci,id=3Dnet1" >>>>> with "info pci", I found the net1, showing as below: >>>>> Bus 0, device 4, function 0: >>>>> Ethernet controller: PCI device 1af4:1000 >>>>> IRQ 0. >>>>> BAR0: I/O at 0xffffffffffffffff [0x001e]. >>>>> BAR1: 32 bit memory at 0xffffffffffffffff [0x00000ffe]. >>>>> BAR6: 32 bit memory at 0xffffffffffffffff [0x0003fffe]. >>>>> id "net1" >>>>> Step 2: I executed " device_del net1", but the net1 still existed. >>>>> >>>>>> In QMP, you get a DEVICE_DELETED event when the unplug completes. >>>> See >>>>>> qmp/qmp-events.txt. >>>>> Actually, I don't get the event, as the net1 can't be unplug. >>>>> >>>>> BTW, when I execute step 1 "device_add virtio-net-pci,id=3Dnet1", I= don't find >>>> the >>>>> Ethernet controller of virtio-net by "lspci " in the guest OS. >>>>> TBH, the command execution failed despite we can see net1 with "inf= o >> pci". >>>> >>>> Sounds like the acpiphp kernel module is not loaded inside the guest= ? >>>> >>> OMG, thank you so much. Good catch. >> >> In that case check your /etc/modprobe.conf file in the SLES guest. Fro= m >> at least SLES 11 SP2 on you should have an entry like this (here SP3): >> >> alias dmi:bvnQEMU:bvrQEMU:* acpiphp >> >> The exact values changed between SeaBIOS versions at some point. >> > Yes, I find the entry in /etc/modprobe.conf file. But I don't understan= d it: >=20 > # QEMU/KVM can handle ACPI Hotplugging > alias dmi:bvnQEMU:bvrQEMU:* acpiphp >=20 > Why not the SLSE OS auto load the acpiphp module when it's booting? This entry is what's supposed to trigger the auto-load on our KVM. :) Like I said above, it depends on the (Sea)BIOS, and you can verify your values by running udevadm monitor --property and while it's monitoring, running udevadm trigger On a recent QEMU I then see KERNEL[761.415335] change /devices/virtual/dmi/id (dmi) ACTION=3Dchange DEVPATH=3D/devices/virtual/dmi/id MODALIAS=3Ddmi:bvnBochs:bvrBochs;bd01/01/2011:svnQEMU:pnStandardPC(i440FX= +PIIX,1996):pvrpc-i440fx-2.0:cvnBochs:ct1:cvr: SEQNUM=3D2896 SUBSYSTEM=3Ddmi So with the SeaBIOS blob from qemu.git, alias dmi:bvnBochs:bvrBochs:* acpiphp would be needed. Once you add it to modprobe.conf I would expect the next `udevadm trigger` (or reboot) to auto-load the module again. SLES 12 has the module built-in and thus no longer depends on this mechanism for auto-loading it. Best regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg