From: Eric Blake <eblake@redhat.com>
To: "Benoît Canet" <benoit.canet@irqsave.net>,
"Lluís Vilanova" <vilanova@ac.upc.edu>
Cc: Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files
Date: Tue, 06 May 2014 09:02:31 -0600 [thread overview]
Message-ID: <5368F987.6030602@redhat.com> (raw)
In-Reply-To: <20140506130740.GA17717@irqsave.net>
[-- Attachment #1: Type: text/plain, Size: 691 bytes --]
On 05/06/2014 07:07 AM, Benoît Canet wrote:
>
> common.json being included in block-core.json and in qapi-schema.json it
> quickly lead some code being generated in double and the compilation to choke.
>
> What do you think would be the best solution to fix this ?
> (Fix the generator ? Make include ignore second inclusion of the same file ?)
I'd argue for the latter - update the parser and the documentation to
state that if a file is included twice, the second inclusion does
nothing. Obviously, the testsuite needs enhancement to test the
solution, as well.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2014-05-06 15:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 13:52 [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files Lluís Vilanova
2014-05-02 13:52 ` [Qemu-devel] [PATCH v12 1/4] qapi: [trivial] Break long command lines Lluís Vilanova
2014-05-02 13:52 ` [Qemu-devel] [PATCH v12 2/4] qapi: [trivial] Do not catch unknown exceptions in "test-qapi.py" Lluís Vilanova
2014-05-02 13:52 ` [Qemu-devel] [PATCH v12 3/4] qapi: Use an explicit input file Lluís Vilanova
2014-05-02 13:52 ` [Qemu-devel] [PATCH v12 4/4] qapi: Add a primitive to include other files from a QAPI schema file Lluís Vilanova
2014-05-05 20:31 ` Luiz Capitulino
2014-05-05 21:15 ` Lluís Vilanova
2014-05-07 18:46 ` Lluís Vilanova
2014-05-07 18:48 ` Lluís Vilanova
2014-05-07 20:44 ` Luiz Capitulino
2014-05-18 11:44 ` Peter Maydell
2014-05-05 18:21 ` [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files Luiz Capitulino
2014-05-07 16:36 ` Luiz Capitulino
2014-05-07 17:07 ` Lluís Vilanova
2014-05-07 17:14 ` Luiz Capitulino
2014-05-07 17:20 ` Lluís Vilanova
2014-05-07 17:23 ` Luiz Capitulino
2014-05-06 13:07 ` Benoît Canet
2014-05-06 13:27 ` Luiz Capitulino
2014-05-06 14:05 ` Benoît Canet
2014-05-06 14:55 ` Eric Blake
2014-05-06 16:55 ` Luiz Capitulino
2014-05-06 17:11 ` Eric Blake
2014-05-07 19:44 ` Markus Armbruster
2014-05-07 20:01 ` Benoît Canet
2014-05-06 15:02 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5368F987.6030602@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).