From: Stefan Weil <sw@weilnetz.de>
To: Alex Bligh <alex@alex.org.uk>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Stanislav Vorobiov <s.vorobiov@samsung.com>,
sangho1206.park@samsung.com, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>,
syeon.hwang@samsung.com
Subject: Re: [Qemu-devel] [PATCH v3] glib: fix g_poll early timeout on windows
Date: Tue, 06 May 2014 18:52:51 +0200 [thread overview]
Message-ID: <53691363.6080802@weilnetz.de> (raw)
In-Reply-To: <A94B205C-9C84-4F29-BD31-1089259D3A84@alex.org.uk>
Am 06.05.2014 17:49, schrieb Alex Bligh:
>
> On 6 May 2014, at 13:38, Paolo Bonzini wrote:
>
>> Il 06/05/2014 14:23, Stefan Hajnoczi ha scritto:
>>>>> Signed-off-by: Stanislav Vorobiov <s.vorobiov@samsung.com>
>>>>> ---
>>>>> include/glib-compat.h | 19 +++++++++
>>>>> include/qemu-common.h | 12 ------
>>>>> util/oslib-win32.c | 112 +++++++++++++++++++++++++++++++++++++++++++++++++
>>>>> 3 files changed, 131 insertions(+), 12 deletions(-)
>>> What is the status of this patch?
>>>
>>> I haven't followed the discussions around the issue but can review/merge
>>> if there is agreement now.
>>
>> The GNOME folks haven't followed up, so I think we should pick it.
>
> I haven't checked it on win32 but was happy with it otherwise.
There was another patch on the list which moved g_poll code from
qemu-common.h to glib-compat.h, so when both patches get merged I expect
a (trivial) merge conflict.
The patch looks good. I already have applied it to my local queue, but I
won't be able to test it before end of next week. If someone wants to
pick it up earlier, I would not mind.
Cheers,
Stefan
next prev parent reply other threads:[~2014-05-06 16:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1397838243-17921-1-git-send-email-s.vorobiov@samsung.com>
2014-05-06 12:23 ` [Qemu-devel] [PATCH v3] glib: fix g_poll early timeout on windows Stefan Hajnoczi
2014-05-06 12:38 ` Paolo Bonzini
2014-05-06 15:49 ` Alex Bligh
2014-05-06 16:52 ` Stefan Weil [this message]
2014-05-07 8:02 ` Stefan Hajnoczi
2014-05-07 8:36 ` Stanislav Vorobiov
2014-05-07 8:49 ` Alex Bligh
2014-05-07 9:06 ` Stanislav Vorobiov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53691363.6080802@weilnetz.de \
--to=sw@weilnetz.de \
--cc=alex@alex.org.uk \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=s.vorobiov@samsung.com \
--cc=sangho1206.park@samsung.com \
--cc=stefanha@redhat.com \
--cc=syeon.hwang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).