From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhicF-0004wd-AD for qemu-devel@nongnu.org; Tue, 06 May 2014 12:53:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Whic7-0000zN-RQ for qemu-devel@nongnu.org; Tue, 06 May 2014 12:53:15 -0400 Received: from v220110690675601.yourvserver.net ([37.221.199.173]:34765) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Whic7-0000ys-L8 for qemu-devel@nongnu.org; Tue, 06 May 2014 12:53:07 -0400 Message-ID: <53691363.6080802@weilnetz.de> Date: Tue, 06 May 2014 18:52:51 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1397838243-17921-1-git-send-email-s.vorobiov@samsung.com> <20140506122304.GH15810@stefanha-thinkpad.redhat.com> <5368D7B8.9010406@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] glib: fix g_poll early timeout on windows List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Bligh , Paolo Bonzini Cc: Stanislav Vorobiov , sangho1206.park@samsung.com, qemu-devel@nongnu.org, Stefan Hajnoczi , syeon.hwang@samsung.com Am 06.05.2014 17:49, schrieb Alex Bligh: > > On 6 May 2014, at 13:38, Paolo Bonzini wrote: > >> Il 06/05/2014 14:23, Stefan Hajnoczi ha scritto: >>>>> Signed-off-by: Stanislav Vorobiov >>>>> --- >>>>> include/glib-compat.h | 19 +++++++++ >>>>> include/qemu-common.h | 12 ------ >>>>> util/oslib-win32.c | 112 +++++++++++++++++++++++++++++++++++++++++++++++++ >>>>> 3 files changed, 131 insertions(+), 12 deletions(-) >>> What is the status of this patch? >>> >>> I haven't followed the discussions around the issue but can review/merge >>> if there is agreement now. >> >> The GNOME folks haven't followed up, so I think we should pick it. > > I haven't checked it on win32 but was happy with it otherwise. There was another patch on the list which moved g_poll code from qemu-common.h to glib-compat.h, so when both patches get merged I expect a (trivial) merge conflict. The patch looks good. I already have applied it to my local queue, but I won't be able to test it before end of next week. If someone wants to pick it up earlier, I would not mind. Cheers, Stefan