From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Whj7B-0007k9-1G for qemu-devel@nongnu.org; Tue, 06 May 2014 13:25:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Whj71-0006Pn-S5 for qemu-devel@nongnu.org; Tue, 06 May 2014 13:25:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21746) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Whj71-0006OY-Jk for qemu-devel@nongnu.org; Tue, 06 May 2014 13:25:03 -0400 Message-ID: <53691AEC.8030800@redhat.com> Date: Tue, 06 May 2014 11:25:00 -0600 From: Eric Blake MIME-Version: 1.0 References: <533B22F2.4030209@windriver.com> <20140506133957.GX15810@stefanha-thinkpad.redhat.com> <5368F719.7070308@windriver.com> In-Reply-To: <5368F719.7070308@windriver.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TKDcVTV90IVGj1HduDsWhpAjg16WxJ7ru" Subject: Re: [Qemu-devel] [libvirt] qemu leaving unix sockets behind after VM is shut down List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chris Friesen , Stefan Hajnoczi Cc: libvir-list@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TKDcVTV90IVGj1HduDsWhpAjg16WxJ7ru Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/06/2014 08:52 AM, Chris Friesen wrote: > Yes, I am in fact using OpenStack/libvirt, and did eventually track dow= n > libvirt as the code that was cleaning up the monitor socket. >=20 > Even so, I think this sort of change would be valid in qemu itself. qem= u > created the files, so really it should be up to qemu to delete them whe= n > it's done with them. >=20 > They're not usable for anything with qemu not running, so there's no > good reason to leave them laying around. In the case of sVirt with SELinux labeling, it's often the case that libvirt has to pre-create the file (as qemu itself is prevented from creating the file itself) - that is also an argument for libvirt doing the cleanup. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --TKDcVTV90IVGj1HduDsWhpAjg16WxJ7ru Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTaRrsAAoJEKeha0olJ0Nq5ikH/jRn3YYXix9Tcoj2V295RTYd p3/ThenPQc6ZMxhdecGQnSe50eTRgXZhnm62ATQvl44ekX2mkLox3QjEqMsr2xs0 LgoJGvsoAxGJm2+q7fgd+NstolRXemn5dOOpmOIAmd+T1So5k87aH64mWguD9/5V fOjCdKnhFucoKaJpyDiBv6KrZaaexsFwzVuoa1EOzGsy/+blqKHTVz+laHe7iaiQ WHsmgzSbir1tZYurCzCRwHs+28VHtzbxD28/o1kglompBQtSbcuDw3FzYjECeCl5 SJ4vIBax6aIvTztR/xp3Q7QMXBG/pDwEye3I82ND0IkHydB7EqXso4tQNjjvS4U= =SIqA -----END PGP SIGNATURE----- --TKDcVTV90IVGj1HduDsWhpAjg16WxJ7ru--