From: Max Reitz <mreitz@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Benoît Canet" <benoit@irqsave.net>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] iotests: Add test for the JSON protocol
Date: Tue, 06 May 2014 22:04:52 +0200 [thread overview]
Message-ID: <53694064.7030805@redhat.com> (raw)
In-Reply-To: <5369403F.3040306@redhat.com>
On 06.05.2014 22:04, Eric Blake wrote:
> On 05/06/2014 01:30 PM, Max Reitz wrote:
>> Add a test for the JSON protocol driver.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> Reviewed-by: Benoit Canet <benoit@irqsave.net>
>> ---
>
>> +echo
>> +echo "=== Testing qemu-img info output ==="
>> +echo
>> +
>> +# This should output information about the image itself, not about the JSON
>> +# block device.
> Is this comment a bit stale, now that there is no separate JSON block
> device?
Probably, yes, I just took it from the old series and was glad it just
worked. :-)
Max
prev parent reply other threads:[~2014-05-06 20:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 19:30 [Qemu-devel] [PATCH 0/4] block: Allow JSON filenames Max Reitz
2014-05-06 19:30 ` [Qemu-devel] [PATCH 1/4] qdict: Add qdict_join() Max Reitz
2014-05-06 19:30 ` [Qemu-devel] [PATCH 2/4] check-qdict: Add test for qdict_join() Max Reitz
2014-05-06 19:30 ` [Qemu-devel] [PATCH 3/4] block: Allow JSON filenames Max Reitz
2014-05-06 19:57 ` Eric Blake
2014-05-06 20:00 ` Max Reitz
2014-05-06 20:28 ` Eric Blake
2014-05-06 20:29 ` Max Reitz
2014-05-07 8:39 ` Kevin Wolf
2014-05-08 17:54 ` Max Reitz
2014-05-06 19:30 ` [Qemu-devel] [PATCH 4/4] iotests: Add test for the JSON protocol Max Reitz
2014-05-06 20:04 ` Eric Blake
2014-05-06 20:04 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53694064.7030805@redhat.com \
--to=mreitz@redhat.com \
--cc=benoit@irqsave.net \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).