From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Whlz5-0001Nr-Br for qemu-devel@nongnu.org; Tue, 06 May 2014 16:29:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Whlyz-00006g-H7 for qemu-devel@nongnu.org; Tue, 06 May 2014 16:29:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61942) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Whlyz-00006O-1V for qemu-devel@nongnu.org; Tue, 06 May 2014 16:28:57 -0400 Message-ID: <53694606.9040007@redhat.com> Date: Tue, 06 May 2014 14:28:54 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399404625-6093-1-git-send-email-mreitz@redhat.com> <1399404625-6093-4-git-send-email-mreitz@redhat.com> <53693EC1.3080303@redhat.com> <53693F40.5040308@redhat.com> In-Reply-To: <53693F40.5040308@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3Qqw3XgcMS7in3dwfF9urtoDLAFAmfUBI" Subject: Re: [Qemu-devel] [PATCH 3/4] block: Allow JSON filenames List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3Qqw3XgcMS7in3dwfF9urtoDLAFAmfUBI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/06/2014 02:00 PM, Max Reitz wrote: >> >> -drive >> file=3D'json:{"driver":"qcow2","file.filename":"foo","backing.file.dri= ver":"raw"}',backing.file.driver=3Dqcow2 >> >> >> looks like it specifies conflicting backing.file.driver options. >> Passing true means that qdict_join silently overwrites the value in >> options to instead be the value in the json string; passing false mean= s >> you could flag the user error. >=20 > Yes, you're right; I'll change it. And of course, bonus points if you enhance the testsuite to provoke the error and prove we detect it :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --3Qqw3XgcMS7in3dwfF9urtoDLAFAmfUBI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTaUYGAAoJEKeha0olJ0NqoA8H/2476qh9oEvPA+ANg3akQzvD IjosRVtAam7v5DcbNVD5/MBVSM1d/QatdnvVxqY83/Sd1zuEmESEDYgn28BOOCLU fvoTZAAx2rxWvKArK9TWOmwS9fJeLtU4wIJ17DFV+eovXLaV03HYn1up3+0UHTZH NZbwFuznVhJCraR4buphlw2f28vBy2Et4MPQcBYTfLYqGKXEaWfD5UJ54HJZ4RxI j39WAheykVmI/r7rGq/R4IjePNSksd6BQMPk8sFkaXGiZEHz2DqjHEg7xCYmRM7l RHw+i3SWmKO4mmcDccgMjU1fnxcB3uzi50Hc2HrIGhwQUURL9xBllH3b8wtKLkc= =rIwz -----END PGP SIGNATURE----- --3Qqw3XgcMS7in3dwfF9urtoDLAFAmfUBI--