From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38170)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Whlzi-0002BU-QR
	for qemu-devel@nongnu.org; Tue, 06 May 2014 16:29:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1WhlzZ-0000LJ-VA
	for qemu-devel@nongnu.org; Tue, 06 May 2014 16:29:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36699)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1WhlzZ-0000LD-OG
	for qemu-devel@nongnu.org; Tue, 06 May 2014 16:29:33 -0400
Message-ID: <53694628.80407@redhat.com>
Date: Tue, 06 May 2014 22:29:28 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1399404625-6093-1-git-send-email-mreitz@redhat.com>
	<1399404625-6093-4-git-send-email-mreitz@redhat.com>
	<53693EC1.3080303@redhat.com> <53693F40.5040308@redhat.com>
	<53694606.9040007@redhat.com>
In-Reply-To: <53694606.9040007@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/4] block: Allow JSON filenames
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, =?UTF-8?B?QmVub8OudCBDYW5ldA==?= <benoit@irqsave.net>, Stefan Hajnoczi <stefanha@redhat.com>

On 06.05.2014 22:28, Eric Blake wrote:
> On 05/06/2014 02:00 PM, Max Reitz wrote:
>
>>> -drive
>>> file='json:{"driver":"qcow2","file.filename":"foo","backing.file.driver":"raw"}',backing.file.driver=qcow2
>>>
>>>
>>> looks like it specifies conflicting backing.file.driver options.
>>> Passing true means that qdict_join silently overwrites the value in
>>> options to instead be the value in the json string; passing false means
>>> you could flag the user error.
>> Yes, you're right; I'll change it.
> And of course, bonus points if you enhance the testsuite to provoke the
> error and prove we detect it :)

Already done. ;-)

Max