From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Benoît Canet" <benoit@irqsave.net>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/4] block: Allow JSON filenames
Date: Tue, 06 May 2014 14:45:02 -0600 [thread overview]
Message-ID: <536949CE.90203@redhat.com> (raw)
In-Reply-To: <1399408159-19118-1-git-send-email-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]
On 05/06/2014 02:29 PM, Max Reitz wrote:
> This series acts as some kind of alternative or v5 to the "block/json:
> Add JSON protocol driver" series. It makes bdrv_open() parse filenames
> prefixed by "json:" as JSON objects (discarding the prefix beforehand)
> and then use the resulting QDict as the options for the block device to
> be opened with a NULL filename.
>
> The purpose of this is that it may sometimes be desirable to specify
> options for a block device where only a filename can be given, e.g., for
> backing files. Using this should obviously be the exception, but it is
> nice to have if actually needed.
>
>
> After having written this series, I do indeed agree that it is much
> nicer than the old version of having a dedicated "virtual" block driver
> for this purpose.
>
> Patches 1 and 2 are taken directly from the block/json v3, patch 4 has
> been enriched by an additional scenario (options given directly and
> through the filename) and its comments have been adapted to the new
> implementation.
Series:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2014-05-06 20:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 20:29 [Qemu-devel] [PATCH v2 0/4] block: Allow JSON filenames Max Reitz
2014-05-06 20:29 ` [Qemu-devel] [PATCH v2 1/4] qdict: Add qdict_join() Max Reitz
2014-05-06 20:29 ` [Qemu-devel] [PATCH v2 2/4] check-qdict: Add test for qdict_join() Max Reitz
2014-05-06 20:29 ` [Qemu-devel] [PATCH v2 3/4] block: Allow JSON filenames Max Reitz
2014-05-06 20:29 ` [Qemu-devel] [PATCH v2 4/4] iotests: Add test for the JSON protocol Max Reitz
2014-05-06 20:45 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536949CE.90203@redhat.com \
--to=eblake@redhat.com \
--cc=benoit@irqsave.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).