From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Cc: jan.kiszka@web.de, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: Fix open flags with BDRV_O_SNAPSHOT
Date: Tue, 06 May 2014 23:01:37 +0200 [thread overview]
Message-ID: <53694DB1.1010603@redhat.com> (raw)
In-Reply-To: <1399371550-5212-1-git-send-email-kwolf@redhat.com>
On 06.05.2014 12:19, Kevin Wolf wrote:
> The immediately visible effect of this patch is that it fixes committing
> a temporary snapshot to its backing file. Previously, it would fail with
> a "permission denied" error because bdrv_inherited_flags() forced the
> backing file to be read-only, ignoring the r/w reopen of bdrv_commit().
>
> The bigger problem this releaved is that the original open flags must
> actually only be applied to the temporary snapshot, and the original
> image file must be treated as a backing file of the temporary snapshot
> and get the right flags for that.
>
> Reported-by: Jan Kiszka <jan.kiszka@web.de>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block.c | 34 +++++++++++++++++++---------------
> include/block/block.h | 2 +-
> tests/qemu-iotests/051 | 4 ++++
> tests/qemu-iotests/051.out | 10 ++++++++++
> 4 files changed, 34 insertions(+), 16 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2014-05-06 21:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 10:19 [Qemu-devel] [PATCH] block: Fix open flags with BDRV_O_SNAPSHOT Kevin Wolf
2014-05-06 11:10 ` Jan Kiszka
2014-05-06 21:03 ` Max Reitz
2014-05-07 8:24 ` Kevin Wolf
2014-05-09 8:14 ` Stefan Hajnoczi
2014-05-06 21:01 ` Max Reitz [this message]
2014-05-07 8:31 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53694DB1.1010603@redhat.com \
--to=mreitz@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).