From: Max Reitz <mreitz@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] block/raw-posix: Try both FIEMAP and SEEK_HOLE
Date: Tue, 06 May 2014 23:48:30 +0200 [thread overview]
Message-ID: <536958AE.1020002@redhat.com> (raw)
In-Reply-To: <53695863.9080009@redhat.com>
On 06.05.2014 23:47, Eric Blake wrote:
> On 05/06/2014 03:18 PM, Eric Blake wrote:
>
>> ...if you are on a file system where SEEK_HOLE triggers the kernel
>> fallback of "entire file is allocated", but where FIEMAP is wired up for
>> that file system, would it make sense to have try_seek_hole return -1 in
>> situations where lseek(s->fd, 0, SEEK_HOLE) returns the end of the file?
>> Even more, should skip_seek_hole be a tri-state?
> On the other hand, such systems are getting vanishingly rare as people
> upgrade to newer kernels. Do we care about catering to them, or is it
> fair game to just tell people to upgrade if they want performance?
How about I'll send v3 and you decide? ;-)
next prev parent reply other threads:[~2014-05-06 21:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 19:00 [Qemu-devel] [PATCH v2] block/raw-posix: Try both FIEMAP and SEEK_HOLE Max Reitz
2014-05-06 21:18 ` Eric Blake
2014-05-06 21:35 ` Max Reitz
2014-05-06 21:47 ` Eric Blake
2014-05-06 21:48 ` Max Reitz [this message]
2014-05-07 5:56 ` Markus Armbruster
2014-05-08 18:35 ` Max Reitz
2014-05-09 8:03 ` Paolo Bonzini
2014-05-11 17:26 ` Christoph Hellwig
2014-05-14 23:13 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536958AE.1020002@redhat.com \
--to=mreitz@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).