From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56684)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WhzbH-00059L-Q5
	for qemu-devel@nongnu.org; Wed, 07 May 2014 07:01:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WhzbB-0000oA-MV
	for qemu-devel@nongnu.org; Wed, 07 May 2014 07:01:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38674)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WhzbB-0000o4-FI
	for qemu-devel@nongnu.org; Wed, 07 May 2014 07:01:17 -0400
Message-ID: <536A1278.1070506@redhat.com>
Date: Wed, 07 May 2014 13:01:12 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1398594570-14015-1-git-send-email-kroosec@gmail.com>
	<20140505143330.0d9794ab@redhat.com>
In-Reply-To: <20140505143330.0d9794ab@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] monitor: Add info qom-tree subcommand.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>, Hani Benhabiles <kroosec@gmail.com>
Cc: armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, afaerber@suse.de

Il 05/05/2014 20:33, Luiz Capitulino ha scritto:
>> +            data = object_property_get_qobject(obj, info->name, NULL);
>> +            if (!data) {
>> +                list = list->next;
>> +                continue;

You could use object_property_print and get rid of a relatively large 
amount of code.

Apart from this, the patch is definitely useful.

Paolo