From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54394)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wenchaoqemu@gmail.com>) id 1Wi1OX-0001oY-E0
	for qemu-devel@nongnu.org; Wed, 07 May 2014 08:56:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wenchaoqemu@gmail.com>) id 1Wi1OO-0002fd-DC
	for qemu-devel@nongnu.org; Wed, 07 May 2014 08:56:21 -0400
Received: from mail-pa0-x233.google.com ([2607:f8b0:400e:c03::233]:52489)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wenchaoqemu@gmail.com>) id 1Wi1OO-0002fW-6p
	for qemu-devel@nongnu.org; Wed, 07 May 2014 08:56:12 -0400
Received: by mail-pa0-f51.google.com with SMTP id kq14so1173551pab.10
	for <qemu-devel@nongnu.org>; Wed, 07 May 2014 05:56:11 -0700 (PDT)
Message-ID: <536A2D5E.5040907@gmail.com>
Date: Wed, 07 May 2014 20:55:58 +0800
From: Wenchao Xia <wenchaoqemu@gmail.com>
MIME-Version: 1.0
References: <1398918422-3019-1-git-send-email-wenchaoqemu@gmail.com>
	<1398918422-3019-8-git-send-email-wenchaoqemu@gmail.com>
	<53625DC4.6040000@redhat.com>
In-Reply-To: <53625DC4.6040000@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH V5 07/28] qapi event: convert SHUTDOWN
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com, armbru@redhat.com, lcapitulino@redhat.com

于 2014/5/1 22:44, Eric Blake 写道:
> On 04/30/2014 10:26 PM, Wenchao Xia wrote:
>> Signed-off-by: Wenchao Xia <wenchaoqemu@gmail.com>
>> ---
>>   vl.c |    3 ++-
>>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> This, and many of the subsequent patches in the series, are a bit
> misleading; I have to go back to 5/28 to make sure that both pieces of
> the conversion are in sync.  Is there a technical reason why you can't
> provide both the qapi definition and the conversion to the new
> qapi_event_send_FOO function in the same patch, one patch per FOO,
> rather than your current split?
>
   No, it is just easy to get conflict to modifiy one file in 20+
patches when rebase, so I modified it once in patch 5/28. I'll adjust
it in next version.