From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wi1Yk-0000sq-D1 for qemu-devel@nongnu.org; Wed, 07 May 2014 09:07:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wi1Ye-0006nP-HX for qemu-devel@nongnu.org; Wed, 07 May 2014 09:06:54 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58228 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wi1Ye-0006nL-BS for qemu-devel@nongnu.org; Wed, 07 May 2014 09:06:48 -0400 Message-ID: <536A2FE7.6020001@suse.de> Date: Wed, 07 May 2014 15:06:47 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] tests/qom-test: Test qom-list on link properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cole Robinson , qemu-devel@nongnu.org Am 12.04.2014 00:07, schrieb Cole Robinson: > But don't test their properties, otherwise we will recurse forever. > Their properties are already tested when we encounter them as child > properties elsewhere in the hierarchy, like /machine/unattached/... >=20 > This would have caught the crash fixed by 92b3eead >=20 > Signed-off-by: Cole Robinson > --- > tests/qom-test.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) Sorry, slipped through... Tested and applied now: https://github.com/afaerber/qemu-cpu/commits/qom-next Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg