From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45004)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1WiJp0-0002Kk-BW
	for qemu-devel@nongnu.org; Thu, 08 May 2014 04:37:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1WiJos-0001Ax-Sn
	for qemu-devel@nongnu.org; Thu, 08 May 2014 04:36:54 -0400
Message-ID: <536B421C.7010609@suse.de>
Date: Thu, 08 May 2014 10:36:44 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1399537603-6905-1-git-send-email-dougkwan@google.com>
	<1399537603-6905-2-git-send-email-dougkwan@google.com>
In-Reply-To: <1399537603-6905-2-git-send-email-dougkwan@google.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] linux-user: Handle ELFv2 PPC64
	binaries in user mode.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Doug Kwan <dougkwan@google.com>
Cc: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>, riku.voipio@iki.fi, qemu-ppc@nongnu.org, qemu-devel@nongnu.org

On 05/08/2014 10:26 AM, Doug Kwan wrote:
> Look at ELF header to determin ABI version on PPC64.  This is required
> for executing the first instruction correctly.
>
> Signed-off-by: Doug Kwan <dougkwan@google.com>
> ---
>   include/elf.h        |  5 +++++
>   linux-user/elfload.c | 17 +++++++++++++++--
>   2 files changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/include/elf.h b/include/elf.h
> index 1599ab2..b39f5db 100644
> --- a/include/elf.h
> +++ b/include/elf.h
> @@ -561,6 +561,11 @@ typedef struct {
>   #define SHF_ALPHA_GPREL		0x10000000
>   
>   
> +/* PowerPC specific definitions.  */
> +
> +/* Processor specific flags for the ELF header e_flags field.  */
> +#define EF_PPC64_ABI		3

Please write bitmasks in hex.

> +
>   /* PowerPC relocations defined by the ABIs */
>   #define R_PPC_NONE		0
>   #define R_PPC_ADDR32		1	/* 32bit absolute address */
> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> index 995f999..b96d64a 100644
> --- a/linux-user/elfload.c
> +++ b/linux-user/elfload.c
> @@ -777,12 +777,18 @@ static uint32_t get_elf_hwcap(void)
>           NEW_AUX_ENT(AT_IGNOREPPC, AT_IGNOREPPC);        \
>       } while (0)
>   
> +static inline uint32_t get_ppc64_abi(struct image_info *infop);
> +
>   static inline void init_thread(struct target_pt_regs *_regs, struct image_info *infop)
>   {
>       _regs->gpr[1] = infop->start_stack;
>   #if defined(TARGET_PPC64) && !defined(TARGET_ABI32)
> -    _regs->gpr[2] = ldq_raw(infop->entry + 8) + infop->load_bias;
> -    infop->entry = ldq_raw(infop->entry) + infop->load_bias;
> +    if (get_ppc64_abi(infop) < 2) {
> +      _regs->gpr[2] = ldq_raw(infop->entry + 8) + infop->load_bias;
> +      infop->entry = ldq_raw(infop->entry) + infop->load_bias;
> +    } else {
> +      _regs->gpr[12] = infop->entry;  /* r12 set to global entry address */

Uli, is this correct? Also, why don't w need to adjust for the load_bias 
with ELFv2 anymore?

> +    }
>   #endif
>       _regs->nip = infop->entry;
>   }
> @@ -1152,6 +1158,13 @@ static inline void init_thread(struct target_pt_regs *regs, struct image_info *i
>   
>   #include "elf.h"
>   
> +#ifdef TARGET_PPC
> +static inline uint32_t get_ppc64_abi(struct image_info *infop)
> +{
> +  return infop->elf_flags & EF_PPC64_ABI;
> +}
> +#endif

I'm not sure this is more readable than doing it inline ... :).


Alex