From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46438)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1WiJvD-0008LB-EC
	for qemu-devel@nongnu.org; Thu, 08 May 2014 04:43:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1WiJv5-0003TD-Tr
	for qemu-devel@nongnu.org; Thu, 08 May 2014 04:43:19 -0400
Received: from cantor2.suse.de ([195.135.220.15]:45590 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1WiJv5-0003T8-NK
	for qemu-devel@nongnu.org; Thu, 08 May 2014 04:43:11 -0400
Message-ID: <536B439E.6090600@suse.de>
Date: Thu, 08 May 2014 10:43:10 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1399485959-15579-1-git-send-email-mjrosato@linux.vnet.ibm.com>
	<1399485959-15579-2-git-send-email-mjrosato@linux.vnet.ibm.com>
	<536A8085.5040005@suse.de> <536A82C9.6060304@linux.vnet.ibm.com>
In-Reply-To: <536A82C9.6060304@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 1/4] vl.c: extend -m option to support
 options for memory hotplug
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Matthew Rosato <mjrosato@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, borntraeger@de.ibm.com, aliguori@amazon.com, imammedo@redhat.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com, rth@twiddle.net

On 05/07/2014 09:00 PM, Matthew Rosato wrote:
> On 05/07/2014 02:50 PM, Alexander Graf wrote:
>> On 05/07/2014 08:05 PM, Matthew Rosato wrote:
>>> From: Igor Mammedov <imammedo@redhat.com>
>>>
>>> From: Igor Mammedov <imammedo@redhat.com>
>>>
>>> Add following parameters:
>>>     "slots" - total number of hotplug memory slots
>>>     "maxmem" - maximum possible memory
>>>
>>> "slots" and "maxmem" should go in pair and "maxmem" should be greater
>>> than "mem" for memory hotplug to be enabled.
>>>
>>> Signed-off-by: Matthew Rosato <mjrosato@linux.vnet.ibm.com>
>> If it's From: Igor, why doesn't the patch have his SoB line?
>>
> I needed to rebase a few lines from Igor's latest version, so I wasn't
> sure if I should put his SoB line until he had a chance to look at it.

Usually (unless you work inside the same company and/or have special 
agreements in place) you maintain the original author's SoB line, put a 
comment line with things you changed below and then add your SoB line.


Alex