From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiK7J-0005MY-P5 for qemu-devel@nongnu.org; Thu, 08 May 2014 04:55:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WiK7C-00080G-7P for qemu-devel@nongnu.org; Thu, 08 May 2014 04:55:49 -0400 Message-ID: <536B468C.7090606@suse.de> Date: Thu, 08 May 2014 10:55:40 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1399537603-6905-1-git-send-email-dougkwan@google.com> <1399537603-6905-3-git-send-email-dougkwan@google.com> <536B42B5.5040300@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/3] PPC: Allow little-endian user mode. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?IkRvdWcgS3dhbiAo6Zec5oyv5b63KSI=?= Cc: riku.voipio@iki.fi, "qemu-ppc@nongnu.org" , QEMU Developers On 05/08/2014 10:49 AM, Doug Kwan (=E9=97=9C=E6=8C=AF=E5=BE=B7) wrote: > If we leave the target mode as big-endian, we need to teach the=20 > elfloader to handle binary of reversed endianness. I have looked into=20 > that possibility as well but find the current approach easier. Please don't top post. Ok, so if we really want to change the code to be able to handle=20 !TARGET_WORDS_BIGENDIAN the whole notion of s->le_mode becomes flawed.=20 Instead, it should get renamed into needs_swab or needs_byteswap or=20 something along those lines. Then we can set it accordingly based on=20 msr_le and target configuration. For the mem_helper.c changes, could you please explain why you have to=20 treat msr_le and needs_byteswap separately? Thanks, Alex