From: Alexander Graf <agraf@suse.de>
To: "\"Doug Kwan (關振德)\"" <dougkwan@google.com>
Cc: riku.voipio@iki.fi, "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 2/3] PPC: Allow little-endian user mode.
Date: Thu, 08 May 2014 11:11:46 +0200 [thread overview]
Message-ID: <536B4A52.8020903@suse.de> (raw)
In-Reply-To: <CAH9SEo7SHJNNuxKNQqEfYh8diEV85uD36M1y8y_LpZfZ7o0SLw@mail.gmail.com>
On 05/08/2014 11:05 AM, Doug Kwan (關振德) wrote:
> There are a few places where we do 128-bit loads/store. We need to
> swap the high/low halves and also do byteswap for each half. Byteswap
> of each half is handled differently depending on
> TARGET_WORDS_BIGENDIAN but the swapping of high/low halves is always
> controlled by msr.le. Would our intention be clearer if defined
> another function swap_high_low_64_bits() instead of msr.le?
This is my last warning about top posting. One more top post and I will
ignore any future email from you.
The explanation makes a lot of sense. This probably just deserves a
quick comment in the code so that nobody stumbles over this when he
looks at it :).
Alex
next prev parent reply other threads:[~2014-05-08 9:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 8:26 [Qemu-devel] [PATCH 0/3] Adding new user mode target ppc64el-linux-user Doug Kwan
2014-05-08 8:26 ` [Qemu-devel] [PATCH 1/3] linux-user: Handle ELFv2 PPC64 binaries in user mode Doug Kwan
2014-05-08 8:36 ` Alexander Graf
2014-05-08 8:43 ` Doug Kwan (關振德)
2014-05-08 8:45 ` Alexander Graf
2014-05-08 13:30 ` Ulrich Weigand
2014-05-08 8:26 ` [Qemu-devel] [PATCH 2/3] PPC: Allow little-endian " Doug Kwan
2014-05-08 8:39 ` Alexander Graf
2014-05-08 8:49 ` Doug Kwan (關振德)
2014-05-08 8:55 ` Alexander Graf
2014-05-08 9:05 ` Doug Kwan (關振德)
2014-05-08 9:11 ` Alexander Graf [this message]
2014-05-08 9:24 ` Doug Kwan (關振德)
2014-05-08 12:39 ` Peter Maydell
2014-05-08 12:44 ` Alexander Graf
2014-05-08 8:26 ` [Qemu-devel] [PATCH 3/3] configure: Add new target ppc64el-linux-user Doug Kwan
2014-05-08 8:41 ` Alexander Graf
2014-05-08 8:46 ` Doug Kwan (關振德)
2014-05-08 8:56 ` Alexander Graf
2014-05-08 9:09 ` Doug Kwan (關振德)
2014-05-08 12:18 ` Andreas Färber
2014-05-08 12:28 ` Peter Maydell
2014-05-08 12:45 ` Alexander Graf
2014-05-08 15:57 ` Doug Kwan (關振德)
2014-05-08 14:41 ` Tom Musta
2014-05-08 15:19 ` Doug Kwan (關振德)
2014-05-08 15:25 ` Peter Maydell
2014-05-08 15:32 ` Doug Kwan (關振德)
2014-05-08 15:41 ` Peter Maydell
2014-05-08 15:51 ` Doug Kwan (關振德)
2014-05-08 15:56 ` Peter Maydell
2014-05-08 15:39 ` Tom Musta
2014-05-08 15:43 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536B4A52.8020903@suse.de \
--to=agraf@suse.de \
--cc=dougkwan@google.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).