From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiKMv-0006yY-Cd for qemu-devel@nongnu.org; Thu, 08 May 2014 05:12:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WiKMl-0004vH-Oi for qemu-devel@nongnu.org; Thu, 08 May 2014 05:11:57 -0400 Message-ID: <536B4A52.8020903@suse.de> Date: Thu, 08 May 2014 11:11:46 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1399537603-6905-1-git-send-email-dougkwan@google.com> <1399537603-6905-3-git-send-email-dougkwan@google.com> <536B42B5.5040300@suse.de> <536B468C.7090606@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/3] PPC: Allow little-endian user mode. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?IkRvdWcgS3dhbiAo6Zec5oyv5b63KSI=?= Cc: riku.voipio@iki.fi, "qemu-ppc@nongnu.org" , QEMU Developers On 05/08/2014 11:05 AM, Doug Kwan (=E9=97=9C=E6=8C=AF=E5=BE=B7) wrote: > There are a few places where we do 128-bit loads/store. We need to=20 > swap the high/low halves and also do byteswap for each half. Byteswap=20 > of each half is handled differently depending on=20 > TARGET_WORDS_BIGENDIAN but the swapping of high/low halves is always=20 > controlled by msr.le. Would our intention be clearer if defined=20 > another function swap_high_low_64_bits() instead of msr.le? This is my last warning about top posting. One more top post and I will=20 ignore any future email from you. The explanation makes a lot of sense. This probably just deserves a=20 quick comment in the code so that nobody stumbles over this when he=20 looks at it :). Alex