qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Don Slutz <dslutz@verizon.com>
To: Mike Day <ncmike@ncultra.org>, qemu-devel@nongnu.org
Cc: blauwirbel@gmail.com
Subject: Re: [Qemu-devel] [PATCH] Update QEMU checkpatch.pl to current linux version
Date: Thu, 08 May 2014 08:43:24 -0400	[thread overview]
Message-ID: <536B7BEC.2020803@terremark.com> (raw)
In-Reply-To: <1399400197-7180-1-git-send-email-ncmike@ncultra.org>

On 05/06/14 14:16, Mike Day wrote:
> This updates scripts/checkpatch.pl to version 0.32. Also,
> forward-ported the QEMU checks for no tabs and correct capitalization
> of "QEMU." Finally, make --no-tree the default option since this will
> be used with Qemu.
>
> Signed-off-by: Mike Day <ncmike@ncultra.org>
> ---
>
> Notes: This is a huge patch and I needed to include white space
> changes to get it applying cleanly.
>
> I've tested this so far with some random patches off the mailing list
> and some others that I've got around. I also tested for some intentional
> errors.
>
>   scripts/checkpatch.pl | 2544 ++++++++++++++++++++++++++++++++++++++++---------
>   1 file changed, 2120 insertions(+), 424 deletions(-)
>
>

I have used to following to see how a new version compares:


k=500;i=0;j=0;for sha in $(git log --no-merges --format=format:"%h" -$k);do let i=$i+1; git show $sha >/tmp/a; clear;echo $i;head -20 /tmp/a; ./scripts/checkpatch.pl --root=. /tmp/a; err=$?; if [ $err != 0 ]; then let j=$j+1;read foo;fi; done;echo Check $i, Bad $j

...
total: 0 errors, 0 warnings, 79 lines checked

/tmp/a has no obvious style problems and is ready for submission.
Check 500, Bad 52

    -Don Slutz

  parent reply	other threads:[~2014-05-08 12:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06 18:16 [Qemu-devel] [PATCH] Update QEMU checkpatch.pl to current linux version Mike Day
2014-05-06 18:28 ` Peter Maydell
2014-05-06 18:59   ` Mike Day
2014-05-06 19:20     ` Peter Maydell
2014-05-07 21:16   ` Hani Benhabiles
2014-05-08 14:58     ` Mike Day
2014-05-08 12:43 ` Don Slutz [this message]
2014-05-08 13:59   ` Markus Armbruster
2014-05-08 14:02     ` Peter Maydell
2014-05-08 15:22       ` Mike Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536B7BEC.2020803@terremark.com \
    --to=dslutz@verizon.com \
    --cc=blauwirbel@gmail.com \
    --cc=ncmike@ncultra.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).