From: Paolo Bonzini <pbonzini@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 09/10] build: simplify and fix fix-obj-vars
Date: Thu, 08 May 2014 16:30:04 +0200 [thread overview]
Message-ID: <536B94EC.1070407@redhat.com> (raw)
In-Reply-To: <536B8C51.9000405@msgid.tls.msk.ru>
Il 08/05/2014 15:53, Michael Tokarev ha scritto:
> 08.05.2014 17:36, Paolo Bonzini wrote:
>> fix-obj-vars has the undesired side effect of breaking -cflags
>> -objs and -libs variables in the toplevel Makefile.objs. The
>> variables in the toplevel Makefile.objs do not need any fix,
>> so fix-obj-vars need not do anything.
>>
> []
>> @@ -228,7 +229,7 @@ endef
>> define unnest-vars
>> $(eval obj := $1)
>> $(eval nested-vars := $2)
>> -$(foreach v,$(nested-vars),$(call fix-obj-vars,$v,$(if $(obj),$(obj)/)))
>> +$(foreach v,$(nested-vars),$(call fix-obj-vars,$v,$(obj)))
>> $(eval old-nested-dirs := )
>> $(call unnest-vars-1)
>> $(if $1,$(foreach v,$(nested-vars),$(eval \
>
> How about ditching 01/10 and replacing it with this 09/10 ?
I was thinking about that, but in the end the two fixes are different,
and given the code is tricky, small patches are preferrable.
Paolo
next prev parent reply other threads:[~2014-05-08 14:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 13:36 [Qemu-devel] [PATCH 00/10] build: pending fixes and improvements Paolo Bonzini
2014-05-08 13:36 ` [Qemu-devel] [PATCH 01/10] build: Fix per-object variables for Makefile.target Paolo Bonzini
2014-05-08 13:36 ` [Qemu-devel] [PATCH 02/10] build: simplify Makefile.target a bit, use just one rule for softmmu Paolo Bonzini
2014-05-08 13:36 ` [Qemu-devel] [PATCH 03/10] build: simplify Makefile.target around unnest-vars invocations Paolo Bonzini
2014-05-08 13:36 ` [Qemu-devel] [PATCH 04/10] Makefile: strip tools and modules too Paolo Bonzini
2014-05-08 13:36 ` [Qemu-devel] [PATCH 05/10] Makefile.target: use $(INSTALL_PROG) for installing, not $(INSTALL) Paolo Bonzini
2014-05-08 13:36 ` [Qemu-devel] [PATCH 06/10] Makefile: use $(INSTALL_LIB) for modules not $(INSTALL_PROG) Paolo Bonzini
2014-05-08 13:36 ` [Qemu-devel] [PATCH 07/10] build: add support for per-object -cflags and -libs to all rules Paolo Bonzini
2014-05-08 13:36 ` [Qemu-devel] [PATCH 08/10] build: convert some obj-specific CFLAGS to use new foo.o-cflags syntax Paolo Bonzini
2014-05-08 13:36 ` [Qemu-devel] [PATCH 09/10] build: simplify and fix fix-obj-vars Paolo Bonzini
2014-05-08 13:53 ` Michael Tokarev
2014-05-08 14:30 ` Paolo Bonzini [this message]
2014-05-08 13:36 ` [Qemu-devel] [PATCH 10/10] libcacard: remove libcacard-specific CFLAGS and LIBS from global vars Paolo Bonzini
2014-05-08 14:50 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536B94EC.1070407@redhat.com \
--to=pbonzini@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).