From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41876)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WiPYc-0001po-7R
	for qemu-devel@nongnu.org; Thu, 08 May 2014 10:44:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WiPYW-0006Sm-27
	for qemu-devel@nongnu.org; Thu, 08 May 2014 10:44:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:6832)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WiPYV-0006Ru-Qy
	for qemu-devel@nongnu.org; Thu, 08 May 2014 10:44:15 -0400
Message-ID: <536B94EC.1070407@redhat.com>
Date: Thu, 08 May 2014 16:30:04 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1399556198-17776-1-git-send-email-pbonzini@redhat.com>
	<1399556198-17776-10-git-send-email-pbonzini@redhat.com>
	<536B8C51.9000405@msgid.tls.msk.ru>
In-Reply-To: <536B8C51.9000405@msgid.tls.msk.ru>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 09/10] build: simplify and fix fix-obj-vars
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org

Il 08/05/2014 15:53, Michael Tokarev ha scritto:
> 08.05.2014 17:36, Paolo Bonzini wrote:
>> fix-obj-vars has the undesired side effect of breaking -cflags
>> -objs and -libs variables in the toplevel Makefile.objs.  The
>> variables in the toplevel Makefile.objs do not need any fix,
>> so fix-obj-vars need not do anything.
>>
> []
>> @@ -228,7 +229,7 @@ endef
>>  define unnest-vars
>>  $(eval obj := $1)
>>  $(eval nested-vars := $2)
>> -$(foreach v,$(nested-vars),$(call fix-obj-vars,$v,$(if $(obj),$(obj)/)))
>> +$(foreach v,$(nested-vars),$(call fix-obj-vars,$v,$(obj)))
>>  $(eval old-nested-dirs := )
>>  $(call unnest-vars-1)
>>  $(if $1,$(foreach v,$(nested-vars),$(eval \
>
> How about ditching 01/10 and replacing it with this 09/10 ?

I was thinking about that, but in the end the two fixes are different, 
and given the code is tricky, small patches are preferrable.

Paolo