From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40636) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiSZd-0001DB-W0 for qemu-devel@nongnu.org; Thu, 08 May 2014 13:57:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WiSZX-00050E-QS for qemu-devel@nongnu.org; Thu, 08 May 2014 13:57:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16168) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiSZX-0004ya-F5 for qemu-devel@nongnu.org; Thu, 08 May 2014 13:57:31 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s48HvUbJ023592 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 8 May 2014 13:57:30 -0400 Message-ID: <536BC587.5020201@redhat.com> Date: Thu, 08 May 2014 19:57:27 +0200 From: Max Reitz MIME-Version: 1.0 References: <1399451504-7886-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1399451504-7886-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] block: Fix bdrv_is_allocated() for short backing files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, stefanha@redhat.com On 07.05.2014 10:31, Kevin Wolf wrote: > bdrv_is_allocated() shouldn't return true for sectors that are > unallocated, but after the end of a short backing file, even though > such sectors are (correctly) marked as containing zeros. > > Signed-off-by: Kevin Wolf > --- > v2: > - Set BDRV_BLOCK_ALLOCATED for !drv->bdrv_co_get_block_status (Max) > > block.c | 10 ++++++---- > include/block/block.h | 11 +++++++---- > 2 files changed, 13 insertions(+), 8 deletions(-) Reviewed-by: Max Reitz