* [Qemu-devel] Question about RAM migration flags
@ 2014-05-08 23:08 Peter Lieven
2014-05-09 2:39 ` ChenLiang
2014-05-09 9:43 ` Dr. David Alan Gilbert
0 siblings, 2 replies; 5+ messages in thread
From: Peter Lieven @ 2014-05-08 23:08 UTC (permalink / raw)
To: qemu-devel@nongnu.org
Cc: Orit Wasserman, quintela, Stefan Hajnoczi, Paolo Bonzini
Hi,
while working on ram migration and reading through the code I realized that
qemu does not stop loading a saved VM or rejecting an incoming migration
if there is a flag in the stream that it does not understand. An unknown flag
is simply ignored.
In the block migration code there is a catch at the end complaining about
unknown flags, but in RAM migration there isn't.
Is this on purpose or an error?
Peter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] Question about RAM migration flags
2014-05-08 23:08 [Qemu-devel] Question about RAM migration flags Peter Lieven
@ 2014-05-09 2:39 ` ChenLiang
2014-05-09 9:43 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 5+ messages in thread
From: ChenLiang @ 2014-05-09 2:39 UTC (permalink / raw)
To: Peter Lieven
Cc: weidong.huang, quintela, qemu-devel@nongnu.org, Orit Wasserman,
Stefan Hajnoczi, Paolo Bonzini
On 2014/5/9 7:08, Peter Lieven wrote:
> Hi,
>
> while working on ram migration and reading through the code I realized that
> qemu does not stop loading a saved VM or rejecting an incoming migration
> if there is a flag in the stream that it does not understand. An unknown flag
> is simply ignored.
>
> In the block migration code there is a catch at the end complaining about
> unknown flags, but in RAM migration there isn't.
>
> Is this on purpose or an error?
>
> Peter
>
>
>
IMO, the flag in ram_load always is correct if the code of ram_save is correct.
Of course, it will be much rubost to do it as block migration.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] Question about RAM migration flags
2014-05-08 23:08 [Qemu-devel] Question about RAM migration flags Peter Lieven
2014-05-09 2:39 ` ChenLiang
@ 2014-05-09 9:43 ` Dr. David Alan Gilbert
2014-05-09 12:40 ` Peter Lieven
1 sibling, 1 reply; 5+ messages in thread
From: Dr. David Alan Gilbert @ 2014-05-09 9:43 UTC (permalink / raw)
To: Peter Lieven
Cc: Paolo Bonzini, qemu-devel@nongnu.org, Stefan Hajnoczi, quintela
* Peter Lieven (pl@kamp.de) wrote:
> Hi,
>
> while working on ram migration and reading through the code I realized that
> qemu does not stop loading a saved VM or rejecting an incoming migration
> if there is a flag in the stream that it does not understand. An unknown flag
> is simply ignored.
>
> In the block migration code there is a catch at the end complaining about
> unknown flags, but in RAM migration there isn't.
>
> Is this on purpose or an error?
I think it's in error; the code doesn't have much checking.
Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] Question about RAM migration flags
2014-05-09 9:43 ` Dr. David Alan Gilbert
@ 2014-05-09 12:40 ` Peter Lieven
2014-05-10 8:33 ` Juan Quintela
0 siblings, 1 reply; 5+ messages in thread
From: Peter Lieven @ 2014-05-09 12:40 UTC (permalink / raw)
To: Dr. David Alan Gilbert
Cc: Paolo Bonzini, qemu-devel@nongnu.org, Stefan Hajnoczi,
quintela@redhat.com
> Am 09.05.2014 um 11:43 schrieb "Dr. David Alan Gilbert" <dgilbert@redhat.com>:
>
> * Peter Lieven (pl@kamp.de) wrote:
>> Hi,
>>
>> while working on ram migration and reading through the code I realized that
>> qemu does not stop loading a saved VM or rejecting an incoming migration
>> if there is a flag in the stream that it does not understand. An unknown flag
>> is simply ignored.
>>
>> In the block migration code there is a catch at the end complaining about
>> unknown flags, but in RAM migration there isn't.
>>
>> Is this on purpose or an error?
>
> I think it's in error; the code doesn't have much checking.
i will prepare a patch.
Peter
>
> Dave
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] Question about RAM migration flags
2014-05-09 12:40 ` Peter Lieven
@ 2014-05-10 8:33 ` Juan Quintela
0 siblings, 0 replies; 5+ messages in thread
From: Juan Quintela @ 2014-05-10 8:33 UTC (permalink / raw)
To: Peter Lieven
Cc: Paolo Bonzini, Dr. David Alan Gilbert, Stefan Hajnoczi,
qemu-devel@nongnu.org
Peter Lieven <pl@kamp.de> wrote:
>> Am 09.05.2014 um 11:43 schrieb "Dr. David Alan Gilbert" <dgilbert@redhat.com>:
>>
>> * Peter Lieven (pl@kamp.de) wrote:
>>> Hi,
>>>
>>> while working on ram migration and reading through the code I realized that
>>> qemu does not stop loading a saved VM or rejecting an incoming migration
>>> if there is a flag in the stream that it does not understand. An unknown flag
>>> is simply ignored.
>>>
>>> In the block migration code there is a catch at the end complaining about
>>> unknown flags, but in RAM migration there isn't.
>>>
>>> Is this on purpose or an error?
>>
>> I think it's in error; the code doesn't have much checking.
>
> i will prepare a patch.
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-05-10 8:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-08 23:08 [Qemu-devel] Question about RAM migration flags Peter Lieven
2014-05-09 2:39 ` ChenLiang
2014-05-09 9:43 ` Dr. David Alan Gilbert
2014-05-09 12:40 ` Peter Lieven
2014-05-10 8:33 ` Juan Quintela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).