From: ChenLiang <chenliang88@huawei.com>
To: Peter Lieven <pl@kamp.de>
Cc: weidong.huang@huawei.com, quintela@redhat.com,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Orit Wasserman <owasserm@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] Question about RAM migration flags
Date: Fri, 9 May 2014 10:39:44 +0800 [thread overview]
Message-ID: <536C3FF0.7010907@huawei.com> (raw)
In-Reply-To: <536C0E5A.2030703@kamp.de>
On 2014/5/9 7:08, Peter Lieven wrote:
> Hi,
>
> while working on ram migration and reading through the code I realized that
> qemu does not stop loading a saved VM or rejecting an incoming migration
> if there is a flag in the stream that it does not understand. An unknown flag
> is simply ignored.
>
> In the block migration code there is a catch at the end complaining about
> unknown flags, but in RAM migration there isn't.
>
> Is this on purpose or an error?
>
> Peter
>
>
>
IMO, the flag in ram_load always is correct if the code of ram_save is correct.
Of course, it will be much rubost to do it as block migration.
next prev parent reply other threads:[~2014-05-09 2:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 23:08 [Qemu-devel] Question about RAM migration flags Peter Lieven
2014-05-09 2:39 ` ChenLiang [this message]
2014-05-09 9:43 ` Dr. David Alan Gilbert
2014-05-09 12:40 ` Peter Lieven
2014-05-10 8:33 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536C3FF0.7010907@huawei.com \
--to=chenliang88@huawei.com \
--cc=owasserm@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).