From: Paolo Bonzini <pbonzini@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>, arei.gonglei@huawei.com
Cc: kraxel@redhat.com, weidong.huang@huawei.com,
qemu-devel@nongnu.org, afaerber@suse.de, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size
Date: Fri, 09 May 2014 13:50:08 +0200 [thread overview]
Message-ID: <536CC0F0.1020508@redhat.com> (raw)
In-Reply-To: <20140509111807.GA22335@work-vm>
Il 09/05/2014 13:18, Dr. David Alan Gilbert ha scritto:
> * arei.gonglei@huawei.com (arei.gonglei@huawei.com) wrote:
>> From: Gonglei <arei.gonglei@huawei.com>
>>
>> when configure a invalid vram size for cirrus card, such as less
>> 2 MB, which will crash qemu. Follow the real hardware, the cirrus
>> card has 4 MB video memory. Also for backward compatibility, accept
>> 8 MB and 16 MB vram size.
>
> virt-manager/libvirt seems to default to 9 MByte of Vram for cirrus,
> so this would break a lot of setups.
libvirt is broken and doesn't use the vram property for anything but QXL.
Paolo
next prev parent reply other threads:[~2014-05-09 12:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 10:21 [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size arei.gonglei
2014-05-09 10:31 ` [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size [checkpatch false positive?] Gerd Hoffmann
2014-05-09 10:40 ` Gonglei (Arei)
2014-05-09 10:54 ` Gerd Hoffmann
2014-05-09 10:59 ` Gonglei (Arei)
2014-05-09 11:53 ` [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size Andreas Färber
2014-05-09 11:18 ` Dr. David Alan Gilbert
2014-05-09 11:50 ` Paolo Bonzini [this message]
2014-05-09 11:54 ` Gerd Hoffmann
2014-05-09 12:02 ` Dr. David Alan Gilbert
2014-05-12 17:05 ` Eric Blake
2014-05-12 17:53 ` Andreas Färber
2014-05-12 17:03 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536CC0F0.1020508@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=arei.gonglei@huawei.com \
--cc=dgilbert@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).