From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WijjF-0004Zo-Vv for qemu-devel@nongnu.org; Fri, 09 May 2014 08:16:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WijjB-0001Ir-61 for qemu-devel@nongnu.org; Fri, 09 May 2014 08:16:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WijjA-0001In-V2 for qemu-devel@nongnu.org; Fri, 09 May 2014 08:16:37 -0400 Message-ID: <536CC0F0.1020508@redhat.com> Date: Fri, 09 May 2014 13:50:08 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1399630869-920-1-git-send-email-arei.gonglei@huawei.com> <20140509111807.GA22335@work-vm> In-Reply-To: <20140509111807.GA22335@work-vm> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" , arei.gonglei@huawei.com Cc: kraxel@redhat.com, weidong.huang@huawei.com, qemu-devel@nongnu.org, afaerber@suse.de, mst@redhat.com Il 09/05/2014 13:18, Dr. David Alan Gilbert ha scritto: > * arei.gonglei@huawei.com (arei.gonglei@huawei.com) wrote: >> From: Gonglei >> >> when configure a invalid vram size for cirrus card, such as less >> 2 MB, which will crash qemu. Follow the real hardware, the cirrus >> card has 4 MB video memory. Also for backward compatibility, accept >> 8 MB and 16 MB vram size. > > virt-manager/libvirt seems to default to 9 MByte of Vram for cirrus, > so this would break a lot of setups. libvirt is broken and doesn't use the vram property for anything but QXL. Paolo