From: "Andreas Färber" <afaerber@suse.de>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: "Huangweidong (C)" <weidong.huang@huawei.com>,
"mst@redhat.com" <mst@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Blue Swirl <blauwirbel@gmail.com>,
Gerd Hoffmann <kraxel@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size
Date: Fri, 09 May 2014 13:53:36 +0200 [thread overview]
Message-ID: <536CC1C0.7070905@suse.de> (raw)
In-Reply-To: <33183CC9F5247A488A2544077AF19020815E751D@SZXEMA503-MBS.china.huawei.com>
Am 09.05.2014 12:59, schrieb Gonglei (Arei):
>> -----Original Message-----
>> From: Gerd Hoffmann [mailto:kraxel@redhat.com]
>> Sent: Friday, May 09, 2014 6:55 PM
>> To: Gonglei (Arei)
>> Cc: qemu-devel@nongnu.org; afaerber@suse.de; mst@redhat.com;
>> pbonzini@redhat.com; Huangweidong (C); Blue Swirl
>> Subject: Re: [PATCH] cirrus_vga: adding sanity check for vram size [checkpatch
>> false positive?]
>>
>> Hi,
>>
>>> BTW, what's your opinion about isa cirrus vga device, Gerd?
>>
>> I'd do the same check there.
>>
> But isa_cirrus_vga_realizefn() has no return value for judgment.
> Adding the isa init function back?
No, realizefn is the replacement for the old initfns. Adding qtests for
verifying that things still work is what's holding up the conversion of
PCI devices.
You need to set *errp via error_setg(errp, "..."); instead of
error_report() and then just return.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-05-09 11:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 10:21 [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size arei.gonglei
2014-05-09 10:31 ` [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size [checkpatch false positive?] Gerd Hoffmann
2014-05-09 10:40 ` Gonglei (Arei)
2014-05-09 10:54 ` Gerd Hoffmann
2014-05-09 10:59 ` Gonglei (Arei)
2014-05-09 11:53 ` Andreas Färber [this message]
2014-05-09 11:18 ` [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size Dr. David Alan Gilbert
2014-05-09 11:50 ` Paolo Bonzini
2014-05-09 11:54 ` Gerd Hoffmann
2014-05-09 12:02 ` Dr. David Alan Gilbert
2014-05-12 17:05 ` Eric Blake
2014-05-12 17:53 ` Andreas Färber
2014-05-12 17:03 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536CC1C0.7070905@suse.de \
--to=afaerber@suse.de \
--cc=arei.gonglei@huawei.com \
--cc=blauwirbel@gmail.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).