From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42193) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WijN1-0001fO-2L for qemu-devel@nongnu.org; Fri, 09 May 2014 07:53:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WijMv-0001fo-F1 for qemu-devel@nongnu.org; Fri, 09 May 2014 07:53:42 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39365 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WijMv-0001fX-8K for qemu-devel@nongnu.org; Fri, 09 May 2014 07:53:37 -0400 Message-ID: <536CC1C0.7070905@suse.de> Date: Fri, 09 May 2014 13:53:36 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1399630869-920-1-git-send-email-arei.gonglei@huawei.com> <1399631470.5213.47.camel@nilsson.home.kraxel.org> <33183CC9F5247A488A2544077AF19020815E7506@SZXEMA503-MBS.china.huawei.com> <1399632879.5213.49.camel@nilsson.home.kraxel.org> <33183CC9F5247A488A2544077AF19020815E751D@SZXEMA503-MBS.china.huawei.com> In-Reply-To: <33183CC9F5247A488A2544077AF19020815E751D@SZXEMA503-MBS.china.huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" Cc: "Huangweidong (C)" , "mst@redhat.com" , "qemu-devel@nongnu.org" , Blue Swirl , Gerd Hoffmann , "pbonzini@redhat.com" Am 09.05.2014 12:59, schrieb Gonglei (Arei): >> -----Original Message----- >> From: Gerd Hoffmann [mailto:kraxel@redhat.com] >> Sent: Friday, May 09, 2014 6:55 PM >> To: Gonglei (Arei) >> Cc: qemu-devel@nongnu.org; afaerber@suse.de; mst@redhat.com; >> pbonzini@redhat.com; Huangweidong (C); Blue Swirl >> Subject: Re: [PATCH] cirrus_vga: adding sanity check for vram size [ch= eckpatch >> false positive?] >> >> Hi, >> >>> BTW, what's your opinion about isa cirrus vga device, Gerd? >> >> I'd do the same check there. >> > But isa_cirrus_vga_realizefn() has no return value for judgment. > Adding the isa init function back? No, realizefn is the replacement for the old initfns. Adding qtests for verifying that things still work is what's holding up the conversion of PCI devices. You need to set *errp via error_setg(errp, "..."); instead of error_report() and then just return. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg