From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WikJP-0003AB-FF for qemu-devel@nongnu.org; Fri, 09 May 2014 08:54:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WikJL-00067l-4A for qemu-devel@nongnu.org; Fri, 09 May 2014 08:54:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WikJK-00067f-RB for qemu-devel@nongnu.org; Fri, 09 May 2014 08:53:59 -0400 Message-ID: <536CD03B.804@redhat.com> Date: Fri, 09 May 2014 14:55:23 +0200 From: Peter Krempa MIME-Version: 1.0 References: <9fb5771060b4b87b8a2f58689fdf58550a82d11f.1399630065.git.pkrempa@redhat.com> <20140509113946.GA26017@stefanha-thinkpad.redhat.com> In-Reply-To: <20140509113946.GA26017@stefanha-thinkpad.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pWClkNjwFVx3Q1nNMpo2HuO9bVAqpbFCW" Subject: Re: [Qemu-devel] [PATCH] gluster: Correctly propagate errors when volume isn't accessible List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pWClkNjwFVx3Q1nNMpo2HuO9bVAqpbFCW Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 05/09/14 13:39, Stefan Hajnoczi wrote: > On Fri, May 09, 2014 at 12:08:10PM +0200, Peter Krempa wrote: =2E.. >=20 > Please use scripts/checkpatch.pl to check coding style in the future. = I > added {} around the if statement body. QEMU always uses curlies even > for 1-statement bodies. Ah, right, sorry about that. I'm used to libvirt's coding style which allows it. I'll use the patch checker next time. >=20 > Thanks, applied to my block tree: > https://github.com/stefanha/qemu/commits/block Thanks. >=20 > Stefan >=20 Peter --pWClkNjwFVx3Q1nNMpo2HuO9bVAqpbFCW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTbNA7AAoJEDbsFqzQGGgrkXIQALVPE3jJuoJz+UojyV7TLP/H 7fG11xabX0xRax4czkzEUPRFSBP3YUdyNPhpqf+GWiLxMMXQWoJUPZkeSts8LGYq 1oHpS4VBkcMAH8qqFR0a5XzFcl8BPUmYIx1joeYX6w8TdfcppMJ/9/Yg9c8nWsOI 1JIZCgBG0bW54YIGGciAuafag11pwkqV7OyFYY6efc/s/izXP+f0yy43zQvC2nC1 fmziurwI8qkkhwHbZZs/1/N3/riWkHA3w/MZ81yH3A1cHRCqzlNT6ap5c/KDVnoX JdJfgJ0m5g03eRwdiHGaLy/koH9ax2EtUPsNFoIfrerELVbkp0QQ5rlsbyqaAzJL +EzBtZnOx1eV1ozGoZVuIeTDsUaWjJydMNiIR1bW2BispxC2RF5iiE2WB2gp9EKo YvgYicn/Lj4JYkWz6UrM4pLcmiR/jifWZl4C8NNgF6DAgw6PL1svW41gXXRQ1rGf ZTuXrYsO3kUxurt5peKTrGgGR7C+oexHc9ikOSBjxdho61JvCE7rNY6g4NFWq1Hz FdUpH+SQq4zLlqUwaTkInDJxLZqfbHm9Q7cBDQW5OP5472WOFQAhC47T7chtJEsE u0OFKcl6R182xi33+43QKudNJAoXiGW2oO2mvBJ3DzbJz8Av+nzV9/1Og6NNB6Wn 723HwK1F4sYeO0kbo9wM =31sS -----END PGP SIGNATURE----- --pWClkNjwFVx3Q1nNMpo2HuO9bVAqpbFCW--