From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wiq4m-0007JY-C1 for qemu-devel@nongnu.org; Fri, 09 May 2014 15:03:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wiq4c-0005dW-CX for qemu-devel@nongnu.org; Fri, 09 May 2014 15:03:20 -0400 Received: from mail-we0-x22b.google.com ([2a00:1450:400c:c03::22b]:35466) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wiq4c-0005d7-3S for qemu-devel@nongnu.org; Fri, 09 May 2014 15:03:10 -0400 Received: by mail-we0-f171.google.com with SMTP id w62so4396036wes.16 for ; Fri, 09 May 2014 12:03:09 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <536D2667.2080503@redhat.com> Date: Fri, 09 May 2014 21:03:03 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1399565391-27833-1-git-send-email-pbonzini@redhat.com> <1399565391-27833-2-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 01/11] hw: use ld_p/st_p instead of ld_raw/st_raw List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Richard Henderson Il 09/05/2014 20:18, Peter Maydell ha scritto: > The virtio parts of this look dubious. What actual > endianness does the virtio spec say that things like the > block device geometry should have in memory? I suspect > we should be using the use-the-virtio-endianness accessors > Greg's on-list patches implement, which renders the > raw-vs-p question moot. In any case you'll probably > have patch conflicts there. It's "target" endianness. Yes, there would be conflicts. > For nseries.c I think I'd prefer we do the checkpatch fixups. > There's no reason we can't do this now (ie we don't wait > on the fixes which make the rest of this series an RFC), Ok. Paolo