From: Brad Smith <brad@comstyle.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Riku Voipio <riku.voipio@linaro.org>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] QEMU build broken
Date: Fri, 09 May 2014 19:02:58 -0400 [thread overview]
Message-ID: <536D5EA2.30307@comstyle.com> (raw)
In-Reply-To: <CAFEAcA9MhSg68dMgeHNzHdBEcfU9+EfjeSzivdJ6KeUxAgOtsg@mail.gmail.com>
On 08/05/14 10:54 AM, Peter Maydell wrote:
> On 8 May 2014 15:47, Brad Smith <brad@comstyle.com> wrote:
>> The following commit broke the build of QEMU..
>>
>> linux-user: remove configure option for setting uname release
>>
>> http://git.qemu.org/?p=qemu.git;a=commit;h=e586822a58b6609edb5ea929e8a4aa394d32389f
>>
>> http://buildbot.b1-systems.de/qemu/builders/default_openbsd_current/builds/752/steps/compile/logs/stdio
>>
>> /buildbot-qemu/default_openbsd_current/build/bsd-user/main.c:46:34: error:
>> use of undeclared identifier 'CONFIG_UNAME_RELEASE'
>
> Ah, bsd-user. Do you actually use it, or is it just
> in the default compile that you're running?
I do not use it personally but it is common sense that commits
must not be breaking the build.
> In this case bsd-user makes no use at all of the
> qemu_uname_release variable so we should probably
> just rip it out (together with the useless command
> line argument that lets the user tweak it).
>
> thanks
> -- PMM
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
next prev parent reply other threads:[~2014-05-09 23:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 14:47 [Qemu-devel] QEMU build broken Brad Smith
2014-05-08 14:54 ` Peter Maydell
2014-05-09 8:57 ` Riku Voipio
2014-05-09 9:55 ` Peter Maydell
2014-05-09 17:26 ` Stacey Son
2014-05-09 23:02 ` Brad Smith [this message]
2014-05-09 23:35 ` Peter Maydell
2014-05-09 23:49 ` Brad Smith
2014-05-09 23:59 ` Peter Maydell
2014-05-10 6:25 ` Markus Armbruster
2014-05-10 6:45 ` Brad Smith
2014-05-10 7:07 ` Paolo Bonzini
2014-05-10 9:18 ` Peter Maydell
2014-05-11 0:22 ` Brad Smith
2014-05-12 9:13 ` Markus Armbruster
-- strict thread matches above, loose matches on Subject: below --
2014-03-16 13:22 Brad Smith
2014-03-16 13:26 ` Peter Maydell
2014-03-16 13:40 ` Marcel Apfelbaum
2014-03-16 14:33 ` Brad Smith
2014-03-16 15:03 ` Peter Maydell
2014-03-16 15:28 ` Brad Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536D5EA2.30307@comstyle.com \
--to=brad@comstyle.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).