From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58288)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1Witps-0000p2-Hk
	for qemu-devel@nongnu.org; Fri, 09 May 2014 19:04:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1Witpo-0003BU-E1
	for qemu-devel@nongnu.org; Fri, 09 May 2014 19:04:12 -0400
Received: from speedy.comstyle.com ([2001:470:1d:8c::2]:32766
	helo=mail.comstyle.com) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1Witpo-00039l-9N
	for qemu-devel@nongnu.org; Fri, 09 May 2014 19:04:08 -0400
Message-ID: <536D5EA2.30307@comstyle.com>
Date: Fri, 09 May 2014 19:02:58 -0400
From: Brad Smith <brad@comstyle.com>
MIME-Version: 1.0
References: <536B9900.2010108@comstyle.com>
	<CAFEAcA9MhSg68dMgeHNzHdBEcfU9+EfjeSzivdJ6KeUxAgOtsg@mail.gmail.com>
In-Reply-To: <CAFEAcA9MhSg68dMgeHNzHdBEcfU9+EfjeSzivdJ6KeUxAgOtsg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] QEMU build broken
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Riku Voipio <riku.voipio@linaro.org>, qemu-devel <qemu-devel@nongnu.org>

On 08/05/14 10:54 AM, Peter Maydell wrote:
> On 8 May 2014 15:47, Brad Smith <brad@comstyle.com> wrote:
>> The following commit broke the build of QEMU..
>>
>> linux-user: remove configure option for setting uname release
>>
>> http://git.qemu.org/?p=qemu.git;a=commit;h=e586822a58b6609edb5ea929e8a4aa394d32389f
>>
>> http://buildbot.b1-systems.de/qemu/builders/default_openbsd_current/builds/752/steps/compile/logs/stdio
>>
>> /buildbot-qemu/default_openbsd_current/build/bsd-user/main.c:46:34: error:
>> use of undeclared identifier 'CONFIG_UNAME_RELEASE'
>
> Ah, bsd-user. Do you actually use it, or is it just
> in the default compile that you're running?

I do not use it personally but it is common sense that commits
must not be breaking the build.

> In this case bsd-user makes no use at all of the
> qemu_uname_release variable so we should probably
> just rip it out (together with the useless command
> line argument that lets the user tweak it).
>
> thanks
> -- PMM


-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.