From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjkT0-0002fb-Sp for qemu-devel@nongnu.org; Mon, 12 May 2014 03:16:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WjkSu-0000fH-S0 for qemu-devel@nongnu.org; Mon, 12 May 2014 03:16:06 -0400 Received: from cantor2.suse.de ([195.135.220.15]:46347 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjkSu-0000fA-MW for qemu-devel@nongnu.org; Mon, 12 May 2014 03:16:00 -0400 Message-ID: <5370752E.6090709@suse.de> Date: Mon, 12 May 2014 09:15:58 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1399041202-26184-1-git-send-email-pbonzini@redhat.com> <1399041202-26184-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1399041202-26184-2-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 1/8] kvm: reset state from the CPU's reset method List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Am 02.05.2014 16:33, schrieb Paolo Bonzini: > Now that we have a CPU object with a reset method, it is better to > keep the KVM reset close to the CPU reset. Using qemu_register_reset > as we do now keeps them far apart. >=20 > With this patch, PPC no longer calls the kvm_arch_ function, so > it can get removed there. Other arches call it from their CPU > reset handler, and the function gets an ARMCPU/X86CPU/S390CPU. >=20 > Note that ARM- and s390-specific functions are called kvm_arm_* > and kvm_s390_*, while x86-specific functions are called kvm_arch_*. > That follows the convention used by the different architectures. > Changing that is the topic of a separate patch. >=20 > Reviewed-by: Gleb Natapov > Reviewed-by: Andreas F=C3=A4rber Re-reviewed, looks good now, please take it through the KVM tree. Thanks, Andreas > Signed-off-by: Paolo Bonzini > --- > include/sysemu/kvm.h | 2 -- > kvm-all.c | 11 ----------- > target-arm/cpu.c | 7 +++++++ > target-arm/kvm32.c | 4 +--- > target-arm/kvm64.c | 2 +- > target-arm/kvm_arm.h | 8 ++++++++ > target-i386/cpu.c | 5 +++++ > target-i386/kvm.c | 3 +-- > target-i386/kvm_i386.h | 1 + > target-ppc/kvm.c | 4 ---- > target-s390x/cpu.c | 4 ++++ > target-s390x/cpu.h | 5 +++++ > target-s390x/kvm.c | 6 ++++-- > 13 files changed, 37 insertions(+), 25 deletions(-) --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg