From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjlKa-00069B-Fm for qemu-devel@nongnu.org; Mon, 12 May 2014 04:11:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WjlKR-00018K-BP for qemu-devel@nongnu.org; Mon, 12 May 2014 04:11:28 -0400 Received: from e06smtp18.uk.ibm.com ([195.75.94.114]:57855) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjlKR-00018D-1F for qemu-devel@nongnu.org; Mon, 12 May 2014 04:11:19 -0400 Received: from /spool/local by e06smtp18.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 12 May 2014 09:11:17 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 19F8817D8047 for ; Mon, 12 May 2014 09:12:22 +0100 (BST) Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251]) by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s4C8BEqT61997174 for ; Mon, 12 May 2014 08:11:14 GMT Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s4C8BDdn013369 for ; Mon, 12 May 2014 02:11:14 -0600 Message-ID: <53708221.7000802@de.ibm.com> Date: Mon, 12 May 2014 10:11:13 +0200 From: Christian Borntraeger MIME-Version: 1.0 References: <1399554218-8262-1-git-send-email-cornelia.huck@de.ibm.com> <1399554218-8262-2-git-send-email-cornelia.huck@de.ibm.com> <53707FDB.4030208@de.ibm.com> <20140512100928.2c749995.cornelia.huck@de.ibm.com> In-Reply-To: <20140512100928.2c749995.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 1/4] s390x: split flic into kvm and non-kvm parts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: qemu-devel@nongnu.org, agraf@suse.de On 12/05/14 10:09, Cornelia Huck wrote: > On Mon, 12 May 2014 10:01:31 +0200 > Christian Borntraeger wrote: > >> On 08/05/14 15:03, Cornelia Huck wrote: >>> Introduce a common parent class for both cases, where kvm and non-kvm >>> can hook up callbacks. This will be used by follow-on patches for >>> adapter registration and mapping. >>> >>> We now always have a flic, regardless of whether we use kvm; the >>> non-kvm implementation just doesn't do anything. >>> >>> Reviewed-by: Jens Freimann >>> Signed-off-by: Cornelia Huck >>> --- >>> default-configs/s390x-softmmu.mak | 3 +- >>> hw/intc/Makefile.objs | 1 + >>> hw/intc/s390_flic.c | 318 ++++-------------------------------- >>> hw/intc/s390_flic_kvm.c | 325 +++++++++++++++++++++++++++++++++++++ >>> include/hw/s390x/s390_flic.h | 51 ++++-- >> >> Shouldnt we move this to include/hw/intc/ ? > > Current code is a bit undecided: Some interrupt controllers (like arm > gic) have their headers in include/hw/intc/, some (like openpic and > xics) in the architecture specific directories. Should we decide to > collect all of those headers in include/hw/intc/, I vote for doing that > in a general sweep. Makes a lot of sense. > >> >> Otherwise: >> Reviewed-by: Christian Borntraeger >> >> >>> 5 files changed, 399 insertions(+), 299 deletions(-) >>> create mode 100644 hw/intc/s390_flic_kvm.c