Re: [Qemu-devel] [Crucial bug] Qemu-2.0.0 do not support virtio-net hot plug/unplug exceed two times

Re: [Qemu-devel] [Crucial bug] Qemu-2.0.0 do not support virtio-net hot plug/unplug exceed two times

[Gonglei (Arei)]

Hi,

> > > Il 26/04/2014 10:56, Gonglei (Arei) ha scritto:
> > > > Public bug reported:
> > > >
> > > > I want to repeated hot-plug/unplug the virtio-net in the latest qemu
> > > upstream
> > > > (commit 839a5547574e57cce62f49bfc50fe1f04b00589a), but I am failed
> at
> > > the
> > > > second time hot plug the virtio-net to guest.
> > > >
> > > > Then I tried to use Qemu-2.0.0 release version, but I got the error too.
> > > >
> > > > Cmdline for vm:
> > > >
> > > > /mnt/sdb/gonglei/qemu/x86_64-softmmu/qemu-system-x86_64
> -enable-kvm
> > > -m 4096 -smp 4 -name sles-et -boot c -drive file=/mnt/sdb/gonglei/image/
> > > sles-3.img -vnc 0.0.0.0:10 -monitor stdio
> > > > QEMU 1.7.50 monitor - type 'help' for more information
> > >
> > > For commit 839a5547574e57cce62f49bfc50fe1f04b00589a you should have
> > > gotten 1.7.90 as the version number.
> > >
> > Maybe just because Peter Maydell merge remote-tracking branch. But it
> doesn't matter.
> >
> > > > (qemu) device_add virtio-net-pci,id=net1
> > > > (qemu) device_del net1
> > > > (qemu) device_add virtio-net-pci,id=net1
> > > > Duplicate ID 'net1' for device
> > > > (qemu)
> > >
> > > I cannot reproduce this on Fedora running the 2.0.0 package from the
> > > virt-preview repository (qemu-system-x86-2.0.0-2.fc20.x86_64).
> > >
> > > For what it's worth, I get this for --version:
> > >
> > > $ qemu-system-x86_64 --version
> > > QEMU emulator version 2.0.0, Copyright (c) 2003-2008 Fabrice Bellard
> > >
> > > and likewise, when starting QEMU with "-monitor stdio":
> > >
> > > QEMU 2.0.0 monitor - type 'help' for more information
> > >
> > I got the QEMU 2.0.0 version from http://wiki.qemu.org/Download
> >
> > The issue was reproduced perforce:
> > UVP:/mnt/sdb/gonglei/code/qemu-2.0.0/x86_64-softmmu
> #./qemu-system-x86_64 -enable-kvm -m 4096 -smp 4 -name sles \
> >  -boot c -drive file=/mnt/sdb/gonglei/image/sles-3.img -vnc 0.0.0.0:10
> -monitor stdio
> > QEMU 2.0.0 monitor - type 'help' for more information
> > (qemu) device_add virtio-net-pci,id=net1
> > (qemu) device_del net1
> > (qemu)  device_add virtio-net-pci,id=net1
> > Duplicate ID 'net1' for device
> > (qemu)
> >
> > Anything wrong? Thanks!
> 
> Issue confirmed with both -monitor and qmp-shell with different other device
> models like e1000.

Thanks. This issue confused me two weeks now, any helps will be appreciated.

Cc'ing Peter and Michael for additional insights.


Best regards,
-Gonglei

Re: [Qemu-devel] [Crucial bug] Qemu-2.0.0 do not support virtio-net hot plug/unplug exceed two times

[Markus Armbruster]

"Gonglei (Arei)" <arei.gonglei@huawei.com> writes:

> Hi,
>
>> > > Il 26/04/2014 10:56, Gonglei (Arei) ha scritto:
>> > > > Public bug reported:
>> > > >
>> > > > I want to repeated hot-plug/unplug the virtio-net in the latest qemu
>> > > upstream
>> > > > (commit 839a5547574e57cce62f49bfc50fe1f04b00589a), but I am failed
>> at
>> > > the
>> > > > second time hot plug the virtio-net to guest.
>> > > >
>> > > > Then I tried to use Qemu-2.0.0 release version, but I got the error too.
>> > > >
>> > > > Cmdline for vm:
>> > > >
>> > > > /mnt/sdb/gonglei/qemu/x86_64-softmmu/qemu-system-x86_64
>> -enable-kvm
>> > > -m 4096 -smp 4 -name sles-et -boot c -drive file=/mnt/sdb/gonglei/image/
>> > > sles-3.img -vnc 0.0.0.0:10 -monitor stdio
>> > > > QEMU 1.7.50 monitor - type 'help' for more information
>> > >
>> > > For commit 839a5547574e57cce62f49bfc50fe1f04b00589a you should have
>> > > gotten 1.7.90 as the version number.
>> > >
>> > Maybe just because Peter Maydell merge remote-tracking branch. But it
>> doesn't matter.
>> >
>> > > > (qemu) device_add virtio-net-pci,id=net1
>> > > > (qemu) device_del net1
>> > > > (qemu) device_add virtio-net-pci,id=net1
>> > > > Duplicate ID 'net1' for device
>> > > > (qemu)
>> > >
>> > > I cannot reproduce this on Fedora running the 2.0.0 package from the
>> > > virt-preview repository (qemu-system-x86-2.0.0-2.fc20.x86_64).
>> > >
>> > > For what it's worth, I get this for --version:
>> > >
>> > > $ qemu-system-x86_64 --version
>> > > QEMU emulator version 2.0.0, Copyright (c) 2003-2008 Fabrice Bellard
>> > >
>> > > and likewise, when starting QEMU with "-monitor stdio":
>> > >
>> > > QEMU 2.0.0 monitor - type 'help' for more information
>> > >
>> > I got the QEMU 2.0.0 version from http://wiki.qemu.org/Download
>> >
>> > The issue was reproduced perforce:
>> > UVP:/mnt/sdb/gonglei/code/qemu-2.0.0/x86_64-softmmu
>> #./qemu-system-x86_64 -enable-kvm -m 4096 -smp 4 -name sles \
>> >  -boot c -drive file=/mnt/sdb/gonglei/image/sles-3.img -vnc 0.0.0.0:10
>> -monitor stdio
>> > QEMU 2.0.0 monitor - type 'help' for more information
>> > (qemu) device_add virtio-net-pci,id=net1
>> > (qemu) device_del net1
>> > (qemu)  device_add virtio-net-pci,id=net1
>> > Duplicate ID 'net1' for device
>> > (qemu)
>> >
>> > Anything wrong? Thanks!
>> 
>> Issue confirmed with both -monitor and qmp-shell with different other device
>> models like e1000.
>
> Thanks. This issue confused me two weeks now, any helps will be appreciated.
>
> Cc'ing Peter and Michael for additional insights.

I suspect your second device_add fails because the unplug initiated by
device_del hasn't completed, yet.

More detailed explanation of the ACPI unplug dance:
https://lists.nongnu.org/archive/html/qemu-devel/2013-03/msg01362.html

Please verify the device is gone with "info pci", "info qtree" or
similar before you try device_del.

In QMP, you get a DEVICE_DELETED event when the unplug completes.  See
qmp/qmp-events.txt.

Re: [Qemu-devel] [Crucial bug] Qemu-2.0.0 do not support virtio-net hot plug/unplug exceed two times

[Gonglei (Arei)]

> >> > > Il 26/04/2014 10:56, Gonglei (Arei) ha scritto:
> >> > > > Public bug reported:
> >> > > >
> >> > > > I want to repeated hot-plug/unplug the virtio-net in the latest qemu
> >> > > upstream
> >> > > > (commit 839a5547574e57cce62f49bfc50fe1f04b00589a), but I am
> failed
> >> at
> >> > > the
> >> > > > second time hot plug the virtio-net to guest.
> >> > > >
> >> > > > Then I tried to use Qemu-2.0.0 release version, but I got the error too.
> >> > > >
> >> > > > Cmdline for vm:
> >> > > >
> >> > > > /mnt/sdb/gonglei/qemu/x86_64-softmmu/qemu-system-x86_64
> >> -enable-kvm
> >> > > -m 4096 -smp 4 -name sles-et -boot c -drive
> file=/mnt/sdb/gonglei/image/
> >> > > sles-3.img -vnc 0.0.0.0:10 -monitor stdio
> >> > > > QEMU 1.7.50 monitor - type 'help' for more information
> >> > >
> >> > > For commit 839a5547574e57cce62f49bfc50fe1f04b00589a you should
> have
> >> > > gotten 1.7.90 as the version number.
> >> > >
> >> > Maybe just because Peter Maydell merge remote-tracking branch. But it
> >> doesn't matter.
> >> >
> >> > > > (qemu) device_add virtio-net-pci,id=net1
> >> > > > (qemu) device_del net1
> >> > > > (qemu) device_add virtio-net-pci,id=net1
> >> > > > Duplicate ID 'net1' for device
> >> > > > (qemu)
> >> > >
> >> > > I cannot reproduce this on Fedora running the 2.0.0 package from the
> >> > > virt-preview repository (qemu-system-x86-2.0.0-2.fc20.x86_64).
> >> > >
> >> > > For what it's worth, I get this for --version:
> >> > >
> >> > > $ qemu-system-x86_64 --version
> >> > > QEMU emulator version 2.0.0, Copyright (c) 2003-2008 Fabrice Bellard
> >> > >
> >> > > and likewise, when starting QEMU with "-monitor stdio":
> >> > >
> >> > > QEMU 2.0.0 monitor - type 'help' for more information
> >> > >
> >> > I got the QEMU 2.0.0 version from http://wiki.qemu.org/Download
> >> >
> >> > The issue was reproduced perforce:
> >> > UVP:/mnt/sdb/gonglei/code/qemu-2.0.0/x86_64-softmmu
> >> #./qemu-system-x86_64 -enable-kvm -m 4096 -smp 4 -name sles \
> >> >  -boot c -drive file=/mnt/sdb/gonglei/image/sles-3.img -vnc 0.0.0.0:10
> >> -monitor stdio
> >> > QEMU 2.0.0 monitor - type 'help' for more information
> >> > (qemu) device_add virtio-net-pci,id=net1
> >> > (qemu) device_del net1
> >> > (qemu)  device_add virtio-net-pci,id=net1
> >> > Duplicate ID 'net1' for device
> >> > (qemu)
> >> >
> >> > Anything wrong? Thanks!
> >>
> >> Issue confirmed with both -monitor and qmp-shell with different other
> device
> >> models like e1000.
> >
> > Thanks. This issue confused me two weeks now, any helps will be
> appreciated.
> >
> > Cc'ing Peter and Michael for additional insights.
> 
> I suspect your second device_add fails because the unplug initiated by
> device_del hasn't completed, yet.
> 
> More detailed explanation of the ACPI unplug dance:
> https://lists.nongnu.org/archive/html/qemu-devel/2013-03/msg01362.html
> 
> Please verify the device is gone with "info pci", "info qtree" or
> similar before you try device_del.
> 
Thank you for reply. I have verified it.

Step 1: I executed "device_add virtio-net-pci,id=net1"
with "info pci", I found the net1, showing as below:
Bus  0, device   4, function 0:
    Ethernet controller: PCI device 1af4:1000
      IRQ 0.
      BAR0: I/O at 0xffffffffffffffff [0x001e].
      BAR1: 32 bit memory at 0xffffffffffffffff [0x00000ffe].
      BAR6: 32 bit memory at 0xffffffffffffffff [0x0003fffe].
      id "net1"
Step 2: I executed " device_del net1", but the net1 still existed.

> In QMP, you get a DEVICE_DELETED event when the unplug completes.  See
> qmp/qmp-events.txt. 
Actually, I don't get the event, as the net1 can't be unplug. 

BTW, when I execute step 1 "device_add virtio-net-pci,id=net1", I don't find the 
Ethernet controller of virtio-net by "lspci " in the guest OS. 
TBH, the command execution failed despite we can see net1 with "info pci".

Would you help me to verify it? Thanks in advance!

Best regards,
-Gonglei

Re: [Qemu-devel] [Crucial bug] Qemu-2.0.0 do not support virtio-net hot plug/unplug exceed two times

[Andreas Färber]

Hi Gonglei,

Am 06.05.2014 14:52, schrieb Gonglei (Arei):
> Step 1: I executed "device_add virtio-net-pci,id=net1"
> with "info pci", I found the net1, showing as below:
> Bus  0, device   4, function 0:
>     Ethernet controller: PCI device 1af4:1000
>       IRQ 0.
>       BAR0: I/O at 0xffffffffffffffff [0x001e].
>       BAR1: 32 bit memory at 0xffffffffffffffff [0x00000ffe].
>       BAR6: 32 bit memory at 0xffffffffffffffff [0x0003fffe].
>       id "net1"
> Step 2: I executed " device_del net1", but the net1 still existed.
> 
>> In QMP, you get a DEVICE_DELETED event when the unplug completes.  See
>> qmp/qmp-events.txt. 
> Actually, I don't get the event, as the net1 can't be unplug. 
> 
> BTW, when I execute step 1 "device_add virtio-net-pci,id=net1", I don't find the 
> Ethernet controller of virtio-net by "lspci " in the guest OS. 
> TBH, the command execution failed despite we can see net1 with "info pci".

Sounds like the acpiphp kernel module is not loaded inside the guest?

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [Crucial bug] Qemu-2.0.0 do not support virtio-net hot plug/unplug exceed two times

[Gonglei (Arei)]

> 
> Am 06.05.2014 14:52, schrieb Gonglei (Arei):
> > Step 1: I executed "device_add virtio-net-pci,id=net1"
> > with "info pci", I found the net1, showing as below:
> > Bus  0, device   4, function 0:
> >     Ethernet controller: PCI device 1af4:1000
> >       IRQ 0.
> >       BAR0: I/O at 0xffffffffffffffff [0x001e].
> >       BAR1: 32 bit memory at 0xffffffffffffffff [0x00000ffe].
> >       BAR6: 32 bit memory at 0xffffffffffffffff [0x0003fffe].
> >       id "net1"
> > Step 2: I executed " device_del net1", but the net1 still existed.
> >
> >> In QMP, you get a DEVICE_DELETED event when the unplug completes.
> See
> >> qmp/qmp-events.txt.
> > Actually, I don't get the event, as the net1 can't be unplug.
> >
> > BTW, when I execute step 1 "device_add virtio-net-pci,id=net1", I don't find
> the
> > Ethernet controller of virtio-net by "lspci " in the guest OS.
> > TBH, the command execution failed despite we can see net1 with "info pci".
> 
> Sounds like the acpiphp kernel module is not loaded inside the guest?
> 
OMG, thank you so much. Good catch.

Best regards,
-Gonglei

Re: [Qemu-devel] [Crucial bug] Qemu-2.0.0 do not support virtio-net hot plug/unplug exceed two times

[Andreas Färber]

Am 06.05.2014 15:41, schrieb Gonglei (Arei):
>>
>> Am 06.05.2014 14:52, schrieb Gonglei (Arei):
>>> Step 1: I executed "device_add virtio-net-pci,id=net1"
>>> with "info pci", I found the net1, showing as below:
>>> Bus  0, device   4, function 0:
>>>     Ethernet controller: PCI device 1af4:1000
>>>       IRQ 0.
>>>       BAR0: I/O at 0xffffffffffffffff [0x001e].
>>>       BAR1: 32 bit memory at 0xffffffffffffffff [0x00000ffe].
>>>       BAR6: 32 bit memory at 0xffffffffffffffff [0x0003fffe].
>>>       id "net1"
>>> Step 2: I executed " device_del net1", but the net1 still existed.
>>>
>>>> In QMP, you get a DEVICE_DELETED event when the unplug completes.
>> See
>>>> qmp/qmp-events.txt.
>>> Actually, I don't get the event, as the net1 can't be unplug.
>>>
>>> BTW, when I execute step 1 "device_add virtio-net-pci,id=net1", I don't find
>> the
>>> Ethernet controller of virtio-net by "lspci " in the guest OS.
>>> TBH, the command execution failed despite we can see net1 with "info pci".
>>
>> Sounds like the acpiphp kernel module is not loaded inside the guest?
>>
> OMG, thank you so much. Good catch.

In that case check your /etc/modprobe.conf file in the SLES guest. From
at least SLES 11 SP2 on you should have an entry like this (here SP3):

alias dmi:bvnQEMU:bvrQEMU:* acpiphp

The exact values changed between SeaBIOS versions at some point.

HTH,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [Crucial bug] Qemu-2.0.0 do not support virtio-net hot plug/unplug exceed two times

[Gonglei (Arei)]

Hi,

> -----Original Message-----
> From: Andreas Färber [mailto:afaerber@suse.de]
> Sent: Tuesday, May 06, 2014 9:58 PM
> To: Gonglei (Arei)
> Cc: Markus Armbruster; Hani Benhabiles; Peter Maydell; Paolo Bonzini;
> Michael S. Tsirkin; qemu-devel@nongnu.org
> Subject: Re: [Qemu-devel] [Crucial bug] Qemu-2.0.0 do not support virtio-net
> hot plug/unplug exceed two times
> 
> Am 06.05.2014 15:41, schrieb Gonglei (Arei):
> >>
> >> Am 06.05.2014 14:52, schrieb Gonglei (Arei):
> >>> Step 1: I executed "device_add virtio-net-pci,id=net1"
> >>> with "info pci", I found the net1, showing as below:
> >>> Bus  0, device   4, function 0:
> >>>     Ethernet controller: PCI device 1af4:1000
> >>>       IRQ 0.
> >>>       BAR0: I/O at 0xffffffffffffffff [0x001e].
> >>>       BAR1: 32 bit memory at 0xffffffffffffffff [0x00000ffe].
> >>>       BAR6: 32 bit memory at 0xffffffffffffffff [0x0003fffe].
> >>>       id "net1"
> >>> Step 2: I executed " device_del net1", but the net1 still existed.
> >>>
> >>>> In QMP, you get a DEVICE_DELETED event when the unplug completes.
> >> See
> >>>> qmp/qmp-events.txt.
> >>> Actually, I don't get the event, as the net1 can't be unplug.
> >>>
> >>> BTW, when I execute step 1 "device_add virtio-net-pci,id=net1", I don't find
> >> the
> >>> Ethernet controller of virtio-net by "lspci " in the guest OS.
> >>> TBH, the command execution failed despite we can see net1 with "info
> pci".
> >>
> >> Sounds like the acpiphp kernel module is not loaded inside the guest?
> >>
> > OMG, thank you so much. Good catch.
> 
> In that case check your /etc/modprobe.conf file in the SLES guest. From
> at least SLES 11 SP2 on you should have an entry like this (here SP3):
> 
> alias dmi:bvnQEMU:bvrQEMU:* acpiphp
> 
> The exact values changed between SeaBIOS versions at some point.
> 
Yes, I find the entry in /etc/modprobe.conf file. But I don't understand it:

# QEMU/KVM can handle ACPI Hotplugging
alias dmi:bvnQEMU:bvrQEMU:* acpiphp

Why not the SLSE OS auto load the acpiphp module when it's booting?

Best regards,
-Gonglei

Re: [Qemu-devel] [Crucial bug] Qemu-2.0.0 do not support virtio-net hot plug/unplug exceed two times

[Andreas Färber]

Hi,

Am 06.05.2014 16:08, schrieb Gonglei (Arei):
>> -----Original Message-----
>> From: Andreas Färber [mailto:afaerber@suse.de]
>> Sent: Tuesday, May 06, 2014 9:58 PM
>> To: Gonglei (Arei)
>> Cc: Markus Armbruster; Hani Benhabiles; Peter Maydell; Paolo Bonzini;
>> Michael S. Tsirkin; qemu-devel@nongnu.org
>> Subject: Re: [Qemu-devel] [Crucial bug] Qemu-2.0.0 do not support virtio-net
>> hot plug/unplug exceed two times
>>
>> Am 06.05.2014 15:41, schrieb Gonglei (Arei):
>>>>
>>>> Am 06.05.2014 14:52, schrieb Gonglei (Arei):
>>>>> Step 1: I executed "device_add virtio-net-pci,id=net1"
>>>>> with "info pci", I found the net1, showing as below:
>>>>> Bus  0, device   4, function 0:
>>>>>     Ethernet controller: PCI device 1af4:1000
>>>>>       IRQ 0.
>>>>>       BAR0: I/O at 0xffffffffffffffff [0x001e].
>>>>>       BAR1: 32 bit memory at 0xffffffffffffffff [0x00000ffe].
>>>>>       BAR6: 32 bit memory at 0xffffffffffffffff [0x0003fffe].
>>>>>       id "net1"
>>>>> Step 2: I executed " device_del net1", but the net1 still existed.
>>>>>
>>>>>> In QMP, you get a DEVICE_DELETED event when the unplug completes.
>>>> See
>>>>>> qmp/qmp-events.txt.
>>>>> Actually, I don't get the event, as the net1 can't be unplug.
>>>>>
>>>>> BTW, when I execute step 1 "device_add virtio-net-pci,id=net1", I don't find
>>>> the
>>>>> Ethernet controller of virtio-net by "lspci " in the guest OS.
>>>>> TBH, the command execution failed despite we can see net1 with "info
>> pci".
>>>>
>>>> Sounds like the acpiphp kernel module is not loaded inside the guest?
>>>>
>>> OMG, thank you so much. Good catch.
>>
>> In that case check your /etc/modprobe.conf file in the SLES guest. From
>> at least SLES 11 SP2 on you should have an entry like this (here SP3):
>>
>> alias dmi:bvnQEMU:bvrQEMU:* acpiphp
>>
>> The exact values changed between SeaBIOS versions at some point.
>>
> Yes, I find the entry in /etc/modprobe.conf file. But I don't understand it:
> 
> # QEMU/KVM can handle ACPI Hotplugging
> alias dmi:bvnQEMU:bvrQEMU:* acpiphp
> 
> Why not the SLSE OS auto load the acpiphp module when it's booting?

This entry is what's supposed to trigger the auto-load on our KVM. :)

Like I said above, it depends on the (Sea)BIOS, and you can verify your
values by running

udevadm monitor --property

and while it's monitoring, running

udevadm trigger

On a recent QEMU I then see

KERNEL[761.415335] change   /devices/virtual/dmi/id (dmi)
ACTION=change
DEVPATH=/devices/virtual/dmi/id
MODALIAS=dmi:bvnBochs:bvrBochs;bd01/01/2011:svnQEMU:pnStandardPC(i440FX+PIIX,1996):pvrpc-i440fx-2.0:cvnBochs:ct1:cvr:
SEQNUM=2896
SUBSYSTEM=dmi

So with the SeaBIOS blob from qemu.git,

alias dmi:bvnBochs:bvrBochs:* acpiphp

would be needed. Once you add it to modprobe.conf I would expect the
next `udevadm trigger` (or reboot) to auto-load the module again.

SLES 12 has the module built-in and thus no longer depends on this
mechanism for auto-loading it.

Best regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [Crucial bug] Qemu-2.0.0 do not support virtio-net hot plug/unplug exceed two times

[Andreas Färber]

Am 06.05.2014 17:02, schrieb Andreas Färber:
> Am 06.05.2014 16:08, schrieb Gonglei (Arei):
>>> -----Original Message-----
>>> From: Andreas Färber [mailto:afaerber@suse.de]
>>> Sent: Tuesday, May 06, 2014 9:58 PM
>>> To: Gonglei (Arei)
>>> Cc: Markus Armbruster; Hani Benhabiles; Peter Maydell; Paolo Bonzini;
>>> Michael S. Tsirkin; qemu-devel@nongnu.org
>>> Subject: Re: [Qemu-devel] [Crucial bug] Qemu-2.0.0 do not support virtio-net
>>> hot plug/unplug exceed two times
>>>
>>>>> Sounds like the acpiphp kernel module is not loaded inside the guest?
>>>>>
>>>> OMG, thank you so much. Good catch.
>>>
>>> In that case check your /etc/modprobe.conf file in the SLES guest. From
>>> at least SLES 11 SP2 on you should have an entry like this (here SP3):
>>>
>>> alias dmi:bvnQEMU:bvrQEMU:* acpiphp
>>>
>>> The exact values changed between SeaBIOS versions at some point.
>>>
>> Yes, I find the entry in /etc/modprobe.conf file. But I don't understand it:
>>
>> # QEMU/KVM can handle ACPI Hotplugging
>> alias dmi:bvnQEMU:bvrQEMU:* acpiphp
>>
>> Why not the SLSE OS auto load the acpiphp module when it's booting?
> 
> This entry is what's supposed to trigger the auto-load on our KVM. :)
> 
> Like I said above, it depends on the (Sea)BIOS, and you can verify your
> values by running
> 
> udevadm monitor --property
> 
> and while it's monitoring, running
> 
> udevadm trigger
> 
> On a recent QEMU I then see
> 
> KERNEL[761.415335] change   /devices/virtual/dmi/id (dmi)
> ACTION=change
> DEVPATH=/devices/virtual/dmi/id
> MODALIAS=dmi:bvnBochs:bvrBochs;bd01/01/2011:svnQEMU:pnStandardPC(i440FX+PIIX,1996):pvrpc-i440fx-2.0:cvnBochs:ct1:cvr:
> SEQNUM=2896
> SUBSYSTEM=dmi
> 
> So with the SeaBIOS blob from qemu.git,
> 
> alias dmi:bvnBochs:bvrBochs:* acpiphp
> 
> would be needed. Once you add it to modprobe.conf I would expect the
> next `udevadm trigger` (or reboot) to auto-load the module again.

SLES 11 SP2 kernels since 2012
(https://bugzilla.novell.com/show_bug.cgi?id=754391) and SP3 should not
need the modprobe.conf entry for "Bochs", since the DMI match was added
to the module itself. So it sounds as if the kernel package is not
up-to-date?

If you do see this problem with a fully-updated SLES guest (kernel-* and
module-init-tools packages), please let us know.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [Crucial bug] Qemu-2.0.0 do not support virtio-net hot plug/unplug exceed two times

[Gonglei (Arei)]

Hi,

> -----Original Message-----
> From: Andreas Färber [mailto:afaerber@suse.de]
> Sent: Monday, May 12, 2014 3:09 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org
> Subject: Re: [Qemu-devel] [Crucial bug] Qemu-2.0.0 do not support virtio-net
> hot plug/unplug exceed two times
> 
> Am 06.05.2014 17:02, schrieb Andreas Färber:
> > Am 06.05.2014 16:08, schrieb Gonglei (Arei):
> >>> -----Original Message-----
> >>> From: Andreas Färber [mailto:afaerber@suse.de]
> >>> Sent: Tuesday, May 06, 2014 9:58 PM
> >>> To: Gonglei (Arei)
> >>> Cc: Markus Armbruster; Hani Benhabiles; Peter Maydell; Paolo Bonzini;
> >>> Michael S. Tsirkin; qemu-devel@nongnu.org
> >>> Subject: Re: [Qemu-devel] [Crucial bug] Qemu-2.0.0 do not support
> virtio-net
> >>> hot plug/unplug exceed two times
> >>>
> >>>>> Sounds like the acpiphp kernel module is not loaded inside the guest?
> >>>>>
> >>>> OMG, thank you so much. Good catch.
> >>>
> >>> In that case check your /etc/modprobe.conf file in the SLES guest. From
> >>> at least SLES 11 SP2 on you should have an entry like this (here SP3):
> >>>
> >>> alias dmi:bvnQEMU:bvrQEMU:* acpiphp
> >>>
> >>> The exact values changed between SeaBIOS versions at some point.
> >>>
> >> Yes, I find the entry in /etc/modprobe.conf file. But I don't understand it:
> >>
> >> # QEMU/KVM can handle ACPI Hotplugging
> >> alias dmi:bvnQEMU:bvrQEMU:* acpiphp
> >>
> >> Why not the SLSE OS auto load the acpiphp module when it's booting?
> >
> > This entry is what's supposed to trigger the auto-load on our KVM. :)
> >
> > Like I said above, it depends on the (Sea)BIOS, and you can verify your
> > values by running
> >
> > udevadm monitor --property
> >
> > and while it's monitoring, running
> >
> > udevadm trigger
> >
> > On a recent QEMU I then see
> >
> > KERNEL[761.415335] change   /devices/virtual/dmi/id (dmi)
> > ACTION=change
> > DEVPATH=/devices/virtual/dmi/id
> >
> MODALIAS=dmi:bvnBochs:bvrBochs;bd01/01/2011:svnQEMU:pnStandardPC(i4
> 40FX+PIIX,1996):pvrpc-i440fx-2.0:cvnBochs:ct1:cvr:
> > SEQNUM=2896
> > SUBSYSTEM=dmi
> >
> > So with the SeaBIOS blob from qemu.git,
> >
> > alias dmi:bvnBochs:bvrBochs:* acpiphp
> >
> > would be needed. Once you add it to modprobe.conf I would expect the
> > next `udevadm trigger` (or reboot) to auto-load the module again.
> 
> SLES 11 SP2 kernels since 2012
> (https://bugzilla.novell.com/show_bug.cgi?id=754391) and SP3 should not
> need the modprobe.conf entry for "Bochs", since the DMI match was added
> to the module itself. So it sounds as if the kernel package is not
> up-to-date?
> 
> If you do see this problem with a fully-updated SLES guest (kernel-* and
> module-init-tools packages), please let us know.
> 
My guest os configuration is:

linux-b2ij:~ # rpm -qa|grep kernel
kernel-source-3.0.76-0.11.1
linux-kernel-headers-2.6.32-1.13.5
kernel-default-devel-3.0.76-0.11.1
kernel-default-base-3.0.76-0.11.1
kernel-default-3.0.76-0.11.1
kernel-firmware-20110923-0.42.49

linux-b2ij:~ # rpm -qa|grep module
libgmodule-2_0-0-2.22.5-0.8.8.1
pam-modules-11-1.22.1
pulseaudio-module-x11-0.9.23-0.7.128
libgmodule-2_0-0-32bit-2.22.5-0.8.8.1
module-init-tools-3.11.1-1.28.5
pam-modules-32bit-11-1.22.1

linux-b2ij:~ # uname -a
Linux linux-b2ij 3.0.76-0.11-default #1 SMP Fri Jun 14 08:21:43 UTC 2013 (ccab990) x86_64 x86_64 x86_64 GNU/Linux
linux-b2ij:~ # cat /etc/SuSE-release 
SUSE Linux Enterprise Server 11 (x86_64)
VERSION = 11
PATCHLEVEL = 3

Best regards,
-Gonglei

Re: [Qemu-devel] [Crucial bug] Qemu-2.0.0 do not support virtio-net hot plug/unplug exceed two times

[Andreas Färber]

Hello,

Am 12.05.2014 10:06, schrieb Gonglei (Arei):
>> -----Original Message-----
>> From: Andreas Färber [mailto:afaerber@suse.de]
>> Sent: Monday, May 12, 2014 3:09 PM
>> To: Gonglei (Arei)
>> Cc: qemu-devel@nongnu.org
>> Subject: Re: [Qemu-devel] [Crucial bug] Qemu-2.0.0 do not support virtio-net
>> hot plug/unplug exceed two times
>>
>> SLES 11 SP2 kernels since 2012
>> (https://bugzilla.novell.com/show_bug.cgi?id=754391) and SP3 should not
>> need the modprobe.conf entry for "Bochs", since the DMI match was added
>> to the module itself. So it sounds as if the kernel package is not
>> up-to-date?
>>
> My guest os configuration is:
> 
> linux-b2ij:~ # rpm -qa|grep kernel
> kernel-source-3.0.76-0.11.1
> linux-kernel-headers-2.6.32-1.13.5
> kernel-default-devel-3.0.76-0.11.1
> kernel-default-base-3.0.76-0.11.1
> kernel-default-3.0.76-0.11.1
> kernel-firmware-20110923-0.42.49
[...]
> linux-b2ij:~ # uname -a
> Linux linux-b2ij 3.0.76-0.11-default #1 SMP Fri Jun 14 08:21:43 UTC 2013 (ccab990) x86_64 x86_64 x86_64 GNU/Linux
> linux-b2ij:~ # cat /etc/SuSE-release 
> SUSE Linux Enterprise Server 11 (x86_64)
> VERSION = 11
> PATCHLEVEL = 3

The latest kernel version on SLES 11 SP3 would be ~3.0.101.
3.0.76 is the version originally shipped for SP3.

Regards,
Andreas

P.S. For the record, the mentioned code can be seen here:
http://kernel.suse.com/cgit/kernel/tree/drivers/pci/hotplug/acpiphp_core.c?h=SLE11-SP3

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg