From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjmHb-0001fM-1B for qemu-devel@nongnu.org; Mon, 12 May 2014 05:12:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WjmHU-0003Pl-Pn for qemu-devel@nongnu.org; Mon, 12 May 2014 05:12:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59666) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjmHU-0003PY-Ip for qemu-devel@nongnu.org; Mon, 12 May 2014 05:12:20 -0400 Message-ID: <53709070.9080706@redhat.com> Date: Mon, 12 May 2014 11:12:16 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1399041202-26184-1-git-send-email-pbonzini@redhat.com> <1399041202-26184-9-git-send-email-pbonzini@redhat.com> <53707E00.4000908@suse.de> In-Reply-To: <53707E00.4000908@suse.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 8/8] x86: correctly implement soft reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" Il 12/05/2014 09:53, Andreas F=E4rber ha scritto: >> > Do not do a hard reset for port 92h, keyboard controller, or cf9h so= ft reset. >> > These only reset the CPU. >> > >> > Reviewed-by: Anthony Liguori >> > Signed-off-by: Paolo Bonzini > Apart from the question of whether cpu_soft_reset() is the right API fo= r > this: Does this result in guest-visible changes that we need to suppres= s > for previous machine types? The changes can be considered bug fixes. If anything did rely on INIT=20 signals resetting nothing but the CPU (for example old 16-bit code that=20 wanted to get out of protected mode), it would be broken without these=20 changes. Paolo