From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjmNI-0006sz-RW for qemu-devel@nongnu.org; Mon, 12 May 2014 05:18:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WjmNB-00059x-El for qemu-devel@nongnu.org; Mon, 12 May 2014 05:18:20 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48856 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjmNB-00059r-8Q for qemu-devel@nongnu.org; Mon, 12 May 2014 05:18:13 -0400 Message-ID: <537091D1.4080004@suse.de> Date: Mon, 12 May 2014 11:18:09 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <201405092010.19482.pisa@cmp.felk.cvut.cz> <201405092014.32116.pisa@cmp.felk.cvut.cz> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] CAN bus simple SJA1000 PCI card emulation for QEMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , Pavel Pisa Cc: Oliver Hartkopp A , jinyang.sia@gmail.com, "qemu-devel@nongnu.org" , linux-can@vger.kernel.org, rtems-devel@rtems.org, Stefan Hajnoczi , Stefan Weil , Paolo Bonzini Am 12.05.2014 11:01, schrieb Peter Crosthwaite: > On Sat, May 10, 2014 at 4:14 AM, Pavel Pisa wro= te: >> The work is based on Jin Yang GSoC 2013 work funded >> by Google and mentored in frame of RTEMS project GSoC >> slot donated to QEMU. Should/can that be recorded in form of his Signed-off-by before yours? >> Update from QEMU-1.4 version and architecture cleanup >> by Pavel Pisa (Czech Technical University in Prague). >> >> The core SJA1000 support is independent of provided >> PCI board. The simple core CAN bus infrastructure >> is independent as well. >> >> Connection to the real host CAN bus network through >> SocketCAN network interface is available for Linux >> host system as well. >> >> Signed-off-by: Pavel Pisa >> --- >> default-configs/pci.mak | 2 + >> hw/net/Makefile.objs | 4 + >> hw/net/can_core.c | 350 +++++++++++++++++++ >> hw/net/can_pci.c | 238 +++++++++++++ >> hw/net/can_sja1000.c | 878 +++++++++++++++++++++++++++++++++++++++= +++++++++ >> hw/net/can_sja1000.h | 163 +++++++++ >> include/net/can_emu.h | 123 +++++++ >> 7 files changed, 1758 insertions(+) >=20 > That's a big patch. And it seems to add a new API/framework, then new > users of that API. Can you add your core as a single patch, then > incrementally bring your devices stuff as subsequent patches? My guess > is this should be about 3 patches - are there any circular deps, > requiring you to bring your three c files all at once or is there a > logical order you can add them for ease of review? True. But before you resend, I'd like to hear Stefan H.'s view of whether CAN should go into hw/net/ at all or into, e.g., hw/can/. Independently of the placement, it's always an interesting question of who will maintain this new infrastructure - I don't see any new MAINTAINERS entries getting added in either patch (NB: a diffstat in 0/2 would've been nice) for patch review. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg