From: Alexander Graf <agraf@suse.de>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: qemu-devel@nongnu.org, Thomas Huth <thuth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2] kvm: Fix enable_cap helpers on older gcc
Date: Mon, 12 May 2014 12:17:01 +0200 [thread overview]
Message-ID: <53709F9D.1080604@suse.de> (raw)
In-Reply-To: <20140512121538.2aebbcee.cornelia.huck@de.ibm.com>
On 12.05.14 12:15, Cornelia Huck wrote:
> On Mon, 12 May 2014 11:51:37 +0200
> Alexander Graf <agraf@suse.de> wrote:
>
>> Commit 40f1ee27aa1 introduced handy helpers for enable_cap calls on
>> vcpu and vm level. Unfortunately some older gcc versions (4.7.1, 4.6)
>> seem to choke on signedness detection in inline created variables:
>>
>> target-ppc/kvm.c: In function 'kvmppc_booke_watchdog_enable':
>> target-ppc/kvm.c:1302:21: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
>> target-ppc/kvm.c: In function 'kvmppc_set_papr':
>> target-ppc/kvm.c:1504:21: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
>>
>> However - thanks to Thomas Huth for the suggestion - we can just cast the
>> offending potentially 0 value to a signed type, making the comparison signed.
>>
>> Signed-off-by: Alexander Graf <agraf@suse.de>
> Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>
> I assume you will take this through your tree?
Yeah, without I can't compile :)
Alex
next prev parent reply other threads:[~2014-05-12 10:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 9:51 [Qemu-devel] [PATCH v2] kvm: Fix enable_cap helpers on older gcc Alexander Graf
2014-05-12 9:56 ` Thomas Huth
2014-05-12 10:15 ` Cornelia Huck
2014-05-12 10:17 ` Alexander Graf [this message]
2014-05-20 10:53 ` Cornelia Huck
2014-05-20 10:53 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53709F9D.1080604@suse.de \
--to=agraf@suse.de \
--cc=cornelia.huck@de.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).