From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wjsl2-0000tZ-QC for qemu-devel@nongnu.org; Mon, 12 May 2014 12:07:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wjskx-0004Aj-9N for qemu-devel@nongnu.org; Mon, 12 May 2014 12:07:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wjskx-0004AB-11 for qemu-devel@nongnu.org; Mon, 12 May 2014 12:07:11 -0400 Message-ID: <5370F1AB.2070502@redhat.com> Date: Mon, 12 May 2014 10:07:07 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399662217-31148-1-git-send-email-stefanha@redhat.com> <1399662217-31148-13-git-send-email-stefanha@redhat.com> In-Reply-To: <1399662217-31148-13-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XJSUPc5eet7329RV2g01onHsIVptUVSbJ" Subject: Re: [Qemu-devel] [PULL 12/17] gluster: Correctly propagate errors when volume isn't accessible List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Peter Maydell , Peter Krempa This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XJSUPc5eet7329RV2g01onHsIVptUVSbJ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/09/2014 01:03 PM, Stefan Hajnoczi wrote: > From: Peter Krempa >=20 > The docs for glfs_init suggest that the function sets errno on every > failure. In fact it doesn't. As other functions such as > qemu_gluster_open() in the gluster block code report their errors based= > on this fact we need to make sure that errno is set on each failure. >=20 > This fixes a crash of qemu-img/qemu when a gluster brick isn't > accessible from given host while the server serving the volume > description is. >=20 > Thread 1 (Thread 0x7ffff7fba740 (LWP 203880)): > #0 0x00007ffff77673f8 in glfs_lseek () from /usr/lib64/libgfapi.so.0 > #1 0x0000555555574a68 in qemu_gluster_getlength () > #2 0x0000555555565742 in refresh_total_sectors () > #3 0x000055555556914f in bdrv_open_common () > #4 0x000055555556e8e8 in bdrv_open () > #5 0x000055555556f02f in bdrv_open_image () > #6 0x000055555556e5f6 in bdrv_open () > #7 0x00005555555c5775 in bdrv_new_open () > #8 0x00005555555c5b91 in img_info () > #9 0x00007ffff62c9c05 in __libc_start_main () from /lib64/libc.so.6 > #10 0x00005555555648ad in _start () >=20 > Signed-off-by: Stefan Hajnoczi > --- Isn't this missing S-o-b from Peter? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --XJSUPc5eet7329RV2g01onHsIVptUVSbJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTcPGrAAoJEKeha0olJ0Nqm+IH/i/RMbq7Wqy7GaeAWexizSdL E4f/vLjDMDl3H8GMpV6ucRCjxTw8j88yXNZ+j+obAdRFHzX9HJBcfROwziP+Q2Hz 42RVlOgJje8j79dTFR9lpWQT3DBgwwQ/CBP3LHHhn85Rpz2vxwBP0Ee1X0q3TY+j v1OIvYy8nWUYKmGWUnzHvFo+Y+XEKOUsIBuLuS712nniCDDsiVG/vBmdAxU+K+ls ckQyBBdfrd7SbQzV/jDtUDBEPVCheTD/N1XRu1JuSM3jgbYD1jnKoJKBSGCazEMl OO3cxML5gFKALiyzzxFEBPkQMbIhcujcyCn7UfXv/0N1NthgU/F2m8lSBo9azNM= =4owO -----END PGP SIGNATURE----- --XJSUPc5eet7329RV2g01onHsIVptUVSbJ--