From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wjt9X-0002iJ-8q for qemu-devel@nongnu.org; Mon, 12 May 2014 12:32:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wjt9S-0003os-BP for qemu-devel@nongnu.org; Mon, 12 May 2014 12:32:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wjt9S-0003od-4s for qemu-devel@nongnu.org; Mon, 12 May 2014 12:32:30 -0400 Message-ID: <5370F79A.4030508@redhat.com> Date: Mon, 12 May 2014 10:32:26 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399898143-28288-1-git-send-email-ncmike@ncultra.org> <5370E340.5090401@redhat.com> <20140512151356.GC4371@noname.redhat.com> <5370E6A0.3030406@redhat.com> <5370EE94.8090703@redhat.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GMADBHDstQXPpaLeWsxs69KRKIi1BoWkW" Subject: Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mike Day Cc: Kevin Wolf , "qemu-devel@nongnu.org" , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GMADBHDstQXPpaLeWsxs69KRKIi1BoWkW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/12/2014 10:05 AM, Mike Day wrote: > On Mon, May 12, 2014 at 11:53 AM, Eric Blake wrote:= >> Ah, but it is: >> >> $ qemu-img create -f qcow2 -o help >> Supported options: >> size Virtual disk size >> compat Compatibility level (0.10 or 1.1) >> backing_file File name of a base image >> backing_fmt Image format of the base image >> encryption Encrypt the image >> cluster_size qcow2 cluster size >> preallocation Preallocation mode (allowed values: off, metadata) >> lazy_refcounts Postpone refcount updates >> >> and more importantly, it only appears in the help output of -f modes >> that actually support a backing file. Contrast: >> >> $ qemu-img create -f raw -o help >> Supported options: >> size Virtual disk size >=20 > This is much more prominent in the top-level help: >=20 > rebase [-q] [-f fmt] [-t cache] [-p] [-u] -b backing_file [-F > backing_fmt] filename 'rebase' lacks -o; so it must continue to document -b. This thread was started in context to the 'create' subcommand, not the 'rebase' subcommand. (Arguably, we may need to add -o to rebase someday, but that's not for this patch) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --GMADBHDstQXPpaLeWsxs69KRKIi1BoWkW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTcPeaAAoJEKeha0olJ0NqPr4H/2dKDRk3zRe3nm9xH/VPdOb5 Fhw5Sv5h5QIhwg6ncN9rOmb6OwG6xrAAmhNY0XbVZm6ZiXtxDdGTZWphBkPB1H0E Vbc+QZi35pneKs4oIbBLc9axWkP2yVR/8dKzMcIHW0yoidS3Rp6wX46if0KHtdeX dnbOGCAHFThbu4nqQAcL6jSstz/F3USU5sfGEJiMtXQfvXDG+smM8nlgek5uAc2E KmbvIamGcWyFMkFGRy4FiycIoxZMJMyrQ/X3W/iEObS7qY9UmKbB8SXvOpr5COix vxHgDDhfdE9xINUB9r4G5Ap6G2l03ZscvEAWL74Apk0VTz9xZG8drum5+A5lvrE= =j4BY -----END PGP SIGNATURE----- --GMADBHDstQXPpaLeWsxs69KRKIi1BoWkW--