From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjtcD-0006HY-AI for qemu-devel@nongnu.org; Mon, 12 May 2014 13:02:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wjtc7-00063X-GH for qemu-devel@nongnu.org; Mon, 12 May 2014 13:02:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56674) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wjtc7-00063T-7o for qemu-devel@nongnu.org; Mon, 12 May 2014 13:02:07 -0400 Message-ID: <5370FE8C.90409@redhat.com> Date: Mon, 12 May 2014 11:02:04 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399898143-28288-1-git-send-email-ncmike@ncultra.org> <5370E340.5090401@redhat.com> <20140512151356.GC4371@noname.redhat.com> <5370E6A0.3030406@redhat.com> <5370EE94.8090703@redhat.com> <5370F79A.4030508@redhat.com> <20140512163643.GD4371@noname.redhat.com> In-Reply-To: <20140512163643.GD4371@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rQdKqGX5xctlwIGvCpXvCTIrgnomix1sU" Subject: Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Mike Day , "qemu-devel@nongnu.org" , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rQdKqGX5xctlwIGvCpXvCTIrgnomix1sU Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/12/2014 10:36 AM, Kevin Wolf wrote: >>> rebase [-q] [-f fmt] [-t cache] [-p] [-u] -b backing_file [-F >>> backing_fmt] filename >> >> 'rebase' lacks -o; so it must continue to document -b. This thread wa= s >> started in context to the 'create' subcommand, not the 'rebase' >> subcommand. (Arguably, we may need to add -o to rebase someday, but >> that's not for this patch) >=20 > What would qemu-img rebase do with -o? It is just for (safely) changing= > the backing file, not for updating options. There is qemu-img amend for= > that, and it does have an -o option. It's a consistency argument. Why can't we have: rebase -o backing_file=3Dfile,backing_fmt=3Dfmt similar to create, instead of having to treat rebase as the oddball command that still takes separate options for two highly related items? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --rQdKqGX5xctlwIGvCpXvCTIrgnomix1sU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTcP6MAAoJEKeha0olJ0NqcJUH/A/qguMmU9q/1V/gsjgCxezG cgb4GWQvMmcnKzuC5khySl7xu4pYsRfs/oUXFxWVTRUkPOfODJ2hj8AmboYTJwTo OqYjI50P6emL51p4HYgusVPpzg3e60mH3UKc7O3lS3sRE4333uiXZiujV649o2K2 OFsuAv6Ay/9KsMHJtxXB1J0f1DhMF8NwZddpeCMK8xNLWpIAQVCd9ITQCWKSB2Ta B4xOm/ccAiIFuc/19+HaBTwLUT0wB9CU1Ic7HsOjVKUiclVzhAXjH+/ryBBmyaJt YixoV5+7dVZwsUO2YeV9DTWxxnH3CvIvYsFB17sVdXdPJYkwEwf65y2kYKFPGa0= =W7hX -----END PGP SIGNATURE----- --rQdKqGX5xctlwIGvCpXvCTIrgnomix1sU--