From: Richard Henderson <rth@twiddle.net>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [RFC PATCH 00/11] Cleanup load/store functions in headers and C files
Date: Mon, 12 May 2014 10:37:13 -0700 [thread overview]
Message-ID: <537106C9.4030908@twiddle.net> (raw)
In-Reply-To: <1399565391-27833-1-git-send-email-pbonzini@redhat.com>
On 05/08/2014 09:09 AM, Paolo Bonzini wrote:
> This series is a prerequisite for improving the SMAP emulation in
> qemu-system-x86_64. SMAP is a Broadwell feature and testing it in the
> kernel is probably the #1 reason why people are using TCG x86 nowadays.
>
> In order to implement some of the SMAP checks correctly, I need to define
> a new set of ld/st functions, similar to ldl_data but with a different
> definition of cpu_mmu_index. This series lets me do that painlessly,
> by simplifying the set of macros expected by softmmu_header.h. This is
> done by patches 2 to 4.
>
> In addition, implementation of the MMU lookups are spread across all C
> files. There is no reason for this, it can be done in cputlb.c directly.
> This is done by patches 5 to 7.
>
> CPU load/store functions are also split around multiple headers: tcg/tcg.h,
> softmmu_header.h, cpu-all.h, exec-all.h. This series consolidates them
> all in a single header, cpu_ldst.h, in patches 8 to 11.
>
> The only reason why this is RFC is that it depends on TCG backends
> stopping their use of helper_ld*_mmu and using instead the new
> "return-address aware" helpers. With this conversion done, helper_ld*_mmu
> are not anymore TCG-related and it makes sense to move them to cpu_ldst.h.
> The only backends left to convert are S390, with patches on the list,
> and MIPS, which should also get done for 2.1.
Bravo.
Patches 2-11:
Reviewed-by: Richard Henderson <rth@twiddle.net>
I'll make sure I get that mips patch set posted this week; I failed to do that
before going on holiday last week.
r~
prev parent reply other threads:[~2014-05-12 17:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 16:09 [Qemu-devel] [RFC PATCH 00/11] Cleanup load/store functions in headers and C files Paolo Bonzini
2014-05-08 16:09 ` [Qemu-devel] [RFC PATCH 01/11] hw: use ld_p/st_p instead of ld_raw/st_raw Paolo Bonzini
2014-05-09 18:18 ` Peter Maydell
2014-05-09 19:03 ` Paolo Bonzini
2014-05-08 16:09 ` [Qemu-devel] [RFC PATCH 02/11] softmmu: start introducing SOFTMMU_CODE_ACCESS in softmmu_header.h Paolo Bonzini
2014-05-08 16:09 ` [Qemu-devel] [RFC PATCH 03/11] softmmu: move MMUSUFFIX under SOFTMMU_CODE_ACCESS Paolo Bonzini
2014-05-08 16:09 ` [Qemu-devel] [RFC PATCH 04/11] softmmu: move definition of CPU_MMU_INDEX to inclusion site, drop ACCESS_TYPE Paolo Bonzini
2014-05-08 16:09 ` [Qemu-devel] [RFC PATCH 05/11] softmmu: move ALIGNED_ONLY to cpu.h Paolo Bonzini
2014-05-08 16:09 ` [Qemu-devel] [RFC PATCH 06/11] softmmu: commonize helper definitions Paolo Bonzini
2014-05-08 16:09 ` [Qemu-devel] [RFC PATCH 07/11] softmmu: move softmmu_template.h out of include/ Paolo Bonzini
2014-05-08 16:09 ` [Qemu-devel] [RFC PATCH 08/11] softmmu: make do_unaligned_access extern Paolo Bonzini
2014-05-13 6:53 ` Andreas Färber
2014-05-13 7:08 ` Paolo Bonzini
2014-05-08 16:09 ` [Qemu-devel] [RFC PATCH 09/11] target-arm: move arm_*_code to a separate file Paolo Bonzini
2014-05-13 7:03 ` Andreas Färber
2014-05-13 9:05 ` Peter Maydell
2014-05-08 16:09 ` [Qemu-devel] [RFC PATCH 10/11] softmmu: introduce cpu_ldst.h Paolo Bonzini
2014-05-08 16:09 ` [Qemu-devel] [RFC PATCH 11/11] softmmu: move all load/store functions to cpu_ldst.h Paolo Bonzini
2014-05-12 17:36 ` Richard Henderson
2014-05-13 7:13 ` Andreas Färber
2014-05-13 7:32 ` Paolo Bonzini
2014-05-12 17:37 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537106C9.4030908@twiddle.net \
--to=rth@twiddle.net \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).