From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjuAF-0001t4-TM for qemu-devel@nongnu.org; Mon, 12 May 2014 13:37:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WjuA9-0001Xt-TU for qemu-devel@nongnu.org; Mon, 12 May 2014 13:37:23 -0400 Received: from mail-qc0-x22a.google.com ([2607:f8b0:400d:c01::22a]:57306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjuA9-0001Xp-Oy for qemu-devel@nongnu.org; Mon, 12 May 2014 13:37:17 -0400 Received: by mail-qc0-f170.google.com with SMTP id i8so8294965qcq.15 for ; Mon, 12 May 2014 10:37:17 -0700 (PDT) Sender: Richard Henderson Message-ID: <537106C9.4030908@twiddle.net> Date: Mon, 12 May 2014 10:37:13 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1399565391-27833-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1399565391-27833-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 00/11] Cleanup load/store functions in headers and C files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org On 05/08/2014 09:09 AM, Paolo Bonzini wrote: > This series is a prerequisite for improving the SMAP emulation in > qemu-system-x86_64. SMAP is a Broadwell feature and testing it in the > kernel is probably the #1 reason why people are using TCG x86 nowadays. > > In order to implement some of the SMAP checks correctly, I need to define > a new set of ld/st functions, similar to ldl_data but with a different > definition of cpu_mmu_index. This series lets me do that painlessly, > by simplifying the set of macros expected by softmmu_header.h. This is > done by patches 2 to 4. > > In addition, implementation of the MMU lookups are spread across all C > files. There is no reason for this, it can be done in cputlb.c directly. > This is done by patches 5 to 7. > > CPU load/store functions are also split around multiple headers: tcg/tcg.h, > softmmu_header.h, cpu-all.h, exec-all.h. This series consolidates them > all in a single header, cpu_ldst.h, in patches 8 to 11. > > The only reason why this is RFC is that it depends on TCG backends > stopping their use of helper_ld*_mmu and using instead the new > "return-address aware" helpers. With this conversion done, helper_ld*_mmu > are not anymore TCG-related and it makes sense to move them to cpu_ldst.h. > The only backends left to convert are S390, with patches on the list, > and MIPS, which should also get done for 2.1. Bravo. Patches 2-11: Reviewed-by: Richard Henderson I'll make sure I get that mips patch set posted this week; I failed to do that before going on holiday last week. r~