From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>,
Dmitry Poletaev <poletaev-qemu@yandex.ru>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] target-i386: fix handling of ZF in btx instructions
Date: Mon, 12 May 2014 14:24:38 -0700 [thread overview]
Message-ID: <53713C16.4010303@twiddle.net> (raw)
In-Reply-To: <CAFEAcA8dtgtUyWZzjxWMq7PSsDQfPWTZ+VDiOphf0m4dk+5_fw@mail.gmail.com>
On 05/07/2014 02:03 AM, Peter Maydell wrote:
> On 6 May 2014 14:33, Dmitry Poletaev <poletaev-qemu@yandex.ru> wrote:
>> Eflags for bt/bts/btr/btc instructions compute as for shift(SAR) instructions. According to Intel A2 manual, for btx instructions zf is unaffected under any condition, but for SAR group, when evaluate eflags, we compute zf.
>
> Isn't this the same bug that's fixed by Richard Henderson's
> patch from last month?
>
> http://patchwork.ozlabs.org/patch/337929/
Yes, thanks for the reminder. Sending pull now.
r~
prev parent reply other threads:[~2014-05-12 21:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 13:33 [Qemu-devel] [PATCH] target-i386: fix handling of ZF in btx instructions Dmitry Poletaev
2014-05-07 6:31 ` Paolo Bonzini
2014-05-07 9:03 ` Peter Maydell
2014-05-12 21:24 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53713C16.4010303@twiddle.net \
--to=rth@twiddle.net \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=poletaev-qemu@yandex.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).