From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wk2uU-0000nB-2q for qemu-devel@nongnu.org; Mon, 12 May 2014 22:57:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wk2uN-00039q-R0 for qemu-devel@nongnu.org; Mon, 12 May 2014 22:57:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19969) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wk2uN-00039l-Eo for qemu-devel@nongnu.org; Mon, 12 May 2014 22:57:35 -0400 Message-ID: <53718A1A.20307@redhat.com> Date: Mon, 12 May 2014 20:57:30 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399511680-12811-1-git-send-email-akong@redhat.com> <1399511680-12811-2-git-send-email-akong@redhat.com> In-Reply-To: <1399511680-12811-2-git-send-email-akong@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Aq7gWVW02kAOJqvrhR0l8g3g5JNwAvj0u" Subject: Re: [Qemu-devel] [PATCH v4 1/3] qapi: fix coding style in parameters list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong , lcapitulino@redhat.com, qemu-devel@nongnu.org Cc: pbonzini@redhat.com, armbru@redhat.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Aq7gWVW02kAOJqvrhR0l8g3g5JNwAvj0u Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/07/2014 07:14 PM, Amos Kong wrote: > The space before pointers is redundant. >=20 > Signed-off-by: Amos Kong > --- > scripts/qapi-visit.py | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) Appears to be unchanged from v2. Missing the Reviewed-by I gave on v2 for the code, and you were even reminded about that in v3. I suggested a better wording for the commit message in v2: A space after * when declaring a pointer type is redundant. but that still hasn't been done. It's frustrating when review comments are not addressed (even if you don't want to make a particular change, at least document why keeping things unchanged is preferable, rather than silently ignoring the review). That said, the change is still correct, so it still deserves: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Aq7gWVW02kAOJqvrhR0l8g3g5JNwAvj0u Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTcYobAAoJEKeha0olJ0NqDBQIAKWj6/EDilf5rgsiIJCrucoR Jf23sXS7RNeoBcnzhYd4ddd8LzTd8Nn7qIBtgybrnQ1oHQS71I/00Gx5cwbYIiTs qQq82pKhjB4KEdVeFdsJU7O4+dnhq1jdpBZm/mI/7hB5a/s98VNWhVoRT0zs8Tmm h1ZbVW5pXLJvr9QnlVoIjskOpN9acXsU97tmaX+t+GfHCwDS8qKDHX8g+IHeF+7a 547fwC3q0qb5Nh/XVq7lq0uEjNzZSN7yCeOUMXEKGODURFGr8ePY9mD50J2G/xKR DO7wgUtTKU6i6JAUVVbs8/lpNQb5ZVDczKnOVKri9pCHJmiEnPdF03p1VTwGgPw= =PuWM -----END PGP SIGNATURE----- --Aq7gWVW02kAOJqvrhR0l8g3g5JNwAvj0u--